From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 3F3A7C54EBE
	for <linux-fsdevel@archiver.kernel.org>; Sun,  8 Jan 2023 17:31:22 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S233253AbjAHRbU (ORCPT
        <rfc822;linux-fsdevel@archiver.kernel.org>);
        Sun, 8 Jan 2023 12:31:20 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57104 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229520AbjAHRbS (ORCPT
        <rfc822;linux-fsdevel@vger.kernel.org>);
        Sun, 8 Jan 2023 12:31:18 -0500
Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F2C6D11C;
        Sun,  8 Jan 2023 09:31:18 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version
        :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description;
        bh=j1yO3Mkjepz9lCRA0UQQCZNzrS+IEn6ws1vaF0OS/0U=; b=B6VDIscmO8fbl4lLFNJU1MLiB+
        h4YPrQ4XMzW3mjzPdC1/aZm7EFAIOa4tyfG4jz5p33Kf1hJa9SdlW2afin0l4qj9l7RsZJ+7hXVDF
        uvWJKdtAxu8r5ZN3SQj7f4sWXoduaVVQpKfU+A9It4vL6rv3IZsLaPpgNNxp0j1sZ/GY90xW/GmNg
        keiKYLORjbKsojiPhFJ2eQqD0oOpWxVpwElJeV2FQ8BRugBMHIz+dgRBmvr7nOHEnCkiaVBSk6mHi
        Gi7BiXT1oWrYyXHBDrb9j782NUw5WXVU3wk5emi6yu/c0v7+8kiIvGlVnCvlFo9dc4rHMa6KaRuuT
        fnqO26jA==;
Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux))
        id 1pEZVq-00Eci3-9x; Sun, 08 Jan 2023 17:31:14 +0000
Date:   Sun, 8 Jan 2023 09:31:14 -0800
From:   Christoph Hellwig <hch@infradead.org>
To:     Andreas Gruenbacher <agruenba@redhat.com>
Cc:     Christoph Hellwig <hch@infradead.org>,
        "Darrick J . Wong" <djwong@kernel.org>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Matthew Wilcox <willy@infradead.org>,
        linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-ext4@vger.kernel.org, cluster-devel@redhat.com
Subject: Re: [PATCH v5 6/9] iomap: Rename page_prepare handler to get_folio
Message-ID: <Y7r94noBbxi7612G@infradead.org>
References: <20221231150919.659533-1-agruenba@redhat.com>
 <20221231150919.659533-7-agruenba@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221231150919.659533-7-agruenba@redhat.com>
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html
Precedence: bulk
List-ID: <linux-fsdevel.vger.kernel.org>
X-Mailing-List: linux-fsdevel@vger.kernel.org

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

although it might make sense to just do the rename in patch 5 which
changes the signature to return a folio?