From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE68EC38142 for ; Tue, 24 Jan 2023 06:48:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233111AbjAXGsJ (ORCPT ); Tue, 24 Jan 2023 01:48:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233086AbjAXGsI (ORCPT ); Tue, 24 Jan 2023 01:48:08 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 986F416308; Mon, 23 Jan 2023 22:48:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=qK+UI3T20FyKYT+3Yux4NeMa3OKVIXfUbAI0ES6PEHs=; b=lXy6NIdgUN5i+NO3ISveIZxeit soM6ieD0NIYSBjBdSGtIx6ZLlKNqdoA30akzbCyc0p8kQVV6o4cOR4olL2RANe+QdT9PJocYiICte CBqPhv6thp1gWCsZK63FoCp39tMz62lIUpvOicKLPwBjP31fsvDjFdbfq+u8/P8TWsUxajZSFwuQ3 Shoc3gKgea71Tne8mJhBPHdmCrNBRcuJaH9ztCJiAcZszDWHPO/Lplp/IzvHFtkliYG1q7Il8Vfn3 CTJk/GW9tD+CsjuGzWqTp+y0R+eiKBKICfAMg35K95zeh3biaAHR78Mx5cZiZxxCOPJliEm1TXvlu rxC18gFw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKD64-002a70-0G; Tue, 24 Jan 2023 06:47:56 +0000 Date: Mon, 23 Jan 2023 22:47:55 -0800 From: Christoph Hellwig To: Johannes Thumshirn Cc: Christoph Hellwig , Chris Mason , Josef Bacik , David Sterba , Damien Le Moal , Naohiro Aota , Qu Wenruo , Jens Axboe , "Darrick J. Wong" , "linux-block@vger.kernel.org" , "linux-btrfs@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" Subject: Re: [PATCH 10/34] btrfs: handle checksum validation and repair at the storage layer Message-ID: References: <20230121065031.1139353-1-hch@lst.de> <20230121065031.1139353-11-hch@lst.de> <4010e363-33d7-485c-99b2-d5b86be2af3b@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4010e363-33d7-485c-99b2-d5b86be2af3b@wdc.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, Jan 23, 2023 at 04:39:29PM +0000, Johannes Thumshirn wrote: > > the following readpage if the sector is actually accessed will > > s/if/of This is really supposed to be an if - readahead is speculative, and thus the actual setor might not actually really be needed in the end.