From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EE47C3DA78 for ; Sat, 14 Jan 2023 00:57:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230144AbjANA5u (ORCPT ); Fri, 13 Jan 2023 19:57:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229870AbjANA5t (ORCPT ); Fri, 13 Jan 2023 19:57:49 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CB606084B; Fri, 13 Jan 2023 16:57:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Rd3Vj9lLZkTiTcTgWc40nMIxJu0kY5xaOD5YAF6BsVI=; b=LLYxhsZxvWu+2FiMz0POAm3zf4 rIvG+7CscM+aZvZNawZpNKl1LEKpNv8yMKia38YrbP7vpTIVHrDe6Qy/yyiiHOVUDVHdvAV4zuXZP LJOWA7ag+O2cXPJCKV2oci5TZNbSqXWj/5o0rIirYT+bvMM86GC28bT7Cp61rQTwlJtjbaFlGm/xb Tw8Y9YoRtt8WyMqwc75JNbCIPIJWLvRB4kqvrZQ5xaau8bq+rFpGsSDUyw0b5nRS+fTA4DCB1R56e jMz100Z1Dk6ghP3VObFTB87w/UM0cliBfhyLMK3cnUsFda5lpl2svN4lttWVhdL+fK2nx8NIrEhRw i87Ll/KQ==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pGUrY-004wHa-O1; Sat, 14 Jan 2023 00:57:36 +0000 Date: Fri, 13 Jan 2023 16:57:36 -0800 From: Luis Chamberlain To: hch@infradead.org, djwong@kernel.org, song@kernel.org, rafael@kernel.org, gregkh@linuxfoundation.org, viro@zeniv.linux.org.uk, jack@suse.cz, bvanassche@acm.org, ebiederm@xmission.com Cc: mchehab@kernel.org, keescook@chromium.org, p.raghav@samsung.com, linux-fsdevel@vger.kernel.org, kernel@tuxforce.de, kexec@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFC v3 05/24] fs: add automatic kernel fs freeze / thaw and remove kthread freezing Message-ID: References: <20230114003409.1168311-1-mcgrof@kernel.org> <20230114003409.1168311-6-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230114003409.1168311-6-mcgrof@kernel.org> Sender: Luis Chamberlain Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Fri, Jan 13, 2023 at 04:33:50PM -0800, Luis Chamberlain wrote: > +#ifdef CONFIG_PM_SLEEP > +static bool super_should_freeze(struct super_block *sb) > +{ > + if (!(sb->s_type->fs_flags & FS_AUTOFREEZE)) > + return false; This is used. > + /* > + * We don't freeze virtual filesystems, we skip those filesystems with > + * no backing device. > + */ > + if (sb->s_bdi == &noop_backing_dev_info) > + return false; I however had dropped this and forgot to update my branch. > + > + return true; > +} So the call to super_should_freeze() is removed and the check for the flag is open coded. Luis