From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 662C6C38147 for ; Wed, 18 Jan 2023 21:33:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229850AbjARVdn (ORCPT ); Wed, 18 Jan 2023 16:33:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229489AbjARVdm (ORCPT ); Wed, 18 Jan 2023 16:33:42 -0500 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [IPv6:2a03:a000:7:0:5054:ff:fe1c:15ff]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87A6B366A2 for ; Wed, 18 Jan 2023 13:33:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=2WuvGVVjPfhcIZhsbkz2EarT7sqqS33Y8zjJm+VJ7vM=; b=fe7L45tMENKiRxn7zi4tRhwwlq Ka5ppExwaE6DFwx/CqB0+37N0aLfxrGY/yR9SU+3bXUd3gORpegWv9nUm+2xC7bL4vmAzx5/INwtP Muh6AjDBr6uaZRUQp5hjyDiAfWKZJcRlsP90J26QDLBymCU0J5DZdzOH28NjQUaoo0Hp253JJ1gJB 9j3DtqzVyJoKWUQzVFGORlGKXga7hvqMNhnbJxggVrWAK1fcbnDifJY4WSVkls5Oqns7E+mEXLKJb kF6HRfCmp8w+gJBHWrYBaHDyf92WPI//I8sS7CAUUG6DlDpar9pHmO6O4wsyehqHizyo0hV2CQBk7 bElPFxdA==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.96 #2 (Red Hat Linux)) id 1pIG3o-002cgd-1s; Wed, 18 Jan 2023 21:33:32 +0000 Date: Wed, 18 Jan 2023 21:33:32 +0000 From: Al Viro To: Christoph Hellwig Cc: Andrew Morton , Mark Fasheh , Joel Becker , Joseph Qi , Evgeniy Dushistov , "Matthew Wilcox (Oracle)" , ocfs2-devel@oss.oracle.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: remove most callers of write_one_page v3 Message-ID: References: <20230118173027.294869-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Al Viro Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Jan 18, 2023 at 09:23:37PM +0000, Al Viro wrote: > On Wed, Jan 18, 2023 at 06:30:20PM +0100, Christoph Hellwig wrote: > > Hi all, > > > > this series removes most users of the write_one_page API. These helpers > > internally call ->writepage which we are gradually removing from the > > kernel. > > > > Changes since v2: > > - more minix error handling fixes > > > > Changes since v1: > > - drop the btrfs changes (queue up in the btrfs tree) > > - drop the finaly move to jfs (can't be done without the btrfs patches) > > - fix the existing minix code to properly propagate errors > > Grabbed. I'll split that into per-fs branches (and synchronize wrt > fixes), fold the kmap_local stuff into that and push out. BTW, do you have the check for minix_delete_entry() failure when called from minix_rename() anywhere in your tree? I don't see that in this series; I'm adding the trivial fix, hopefully that won't end up creating conflicts...