From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99E5CC38147 for ; Wed, 18 Jan 2023 22:28:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229872AbjARW2k (ORCPT ); Wed, 18 Jan 2023 17:28:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229590AbjARW2j (ORCPT ); Wed, 18 Jan 2023 17:28:39 -0500 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [IPv6:2a03:a000:7:0:5054:ff:fe1c:15ff]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60BB847EF4; Wed, 18 Jan 2023 14:28:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=APHnihkvh6akIJoj4c5GkeVGlAwab1fmi7yS7P0+eVE=; b=OBnZcUmXTTO10NSukCkw8X+SvB LfNQMY3RQ0VWJHpreSNm3NjMABxMz9VXfPjhN92XoyIAl+24oZ3jNQijW8vm77+gsuwktPSjsMRq6 IYVUZEnd4i3cWegq5edOuLS6FV1Q2igAw/Douzt66Zqk76E0tUgPiHFj69cDlY43UxNEA2rULRF+q GLoeI9Cb0klfiQZjyvDMHiZzRHc6hFLjudz+y65ZyHzw/XxFn/Grpe2nAb2U29AChtNHdX3QG9Jar FzBeJcd9cQ1wEr3maNN4dbCFSXA2DY7mBoFjLWcU+u37osN9R4zLCrIfFxouR9AYOeKIL3QHNWU2V H3jVbE9Q==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.96 #2 (Red Hat Linux)) id 1pIGuz-002d7w-05; Wed, 18 Jan 2023 22:28:29 +0000 Date: Wed, 18 Jan 2023 22:28:28 +0000 From: Al Viro To: Christoph Hellwig Cc: David Howells , Matthew Wilcox , Jens Axboe , Jan Kara , Jeff Layton , Logan Gunthorpe , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 06/34] iov_iter: Use the direction in the iterator functions Message-ID: References: <167391047703.2311931.8115712773222260073.stgit@warthog.procyon.org.uk> <167391052497.2311931.9463379582932734164.stgit@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Al Viro Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, Jan 16, 2023 at 11:58:16PM -0800, Christoph Hellwig wrote: > On Mon, Jan 16, 2023 at 11:08:44PM +0000, David Howells wrote: > > Use the direction in the iterator functions rather than READ/WRITE. > > I don't think we need the direction at all as nothing uses it any more. ... except for checks in copy_from_iter() et.al.