linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: dchinner@redhat.com
Cc: linux-fsdevel@vger.kernel.org
Subject: [bug report] iomap: write iomap validity checks
Date: Fri, 20 Jan 2023 16:47:04 +0300	[thread overview]
Message-ID: <Y8qbWDfLGqUDnbsz@kili> (raw)

Hello Dave Chinner,

The patch d7b64041164c: "iomap: write iomap validity checks" from Nov
29, 2022, leads to the following Smatch static checker warning:

	fs/iomap/buffered-io.c:829 iomap_write_iter()
	error: uninitialized symbol 'folio'.

fs/iomap/buffered-io.c
    818                 if (unlikely(fault_in_iov_iter_readable(i, bytes) == bytes)) {
    819                         status = -EFAULT;
    820                         break;
    821                 }
    822 
    823                 status = iomap_write_begin(iter, pos, bytes, &folio);
                                                                     ^^^^^^^
The iomap_write_begin() function can succeed without initializing
*foliop.  It's next to the big comment.

    824                 if (unlikely(status))
    825                         break;
    826                 if (iter->iomap.flags & IOMAP_F_STALE)
    827                         break;
    828 
--> 829                 page = folio_file_page(folio, pos >> PAGE_SHIFT);
                                               ^^^^^

    830                 if (mapping_writably_mapped(mapping))
    831                         flush_dcache_page(page);
    832 
    833                 copied = copy_page_from_iter_atomic(page, offset, bytes, i);
    834 
    835                 status = iomap_write_end(iter, pos, bytes, copied, folio);
    836 
    837                 if (unlikely(copied != status))
    838                         iov_iter_revert(i, copied - status);
    839 

regards,
dan carpenter

             reply	other threads:[~2023-01-20 13:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-20 13:47 Dan Carpenter [this message]
2023-01-20 16:16 ` [bug report] iomap: write iomap validity checks Matthew Wilcox
2023-01-23  6:55   ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y8qbWDfLGqUDnbsz@kili \
    --to=error27@gmail.com \
    --cc=dchinner@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).