From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4125C25B50 for ; Tue, 24 Jan 2023 19:50:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234799AbjAXTuH (ORCPT ); Tue, 24 Jan 2023 14:50:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234225AbjAXTuG (ORCPT ); Tue, 24 Jan 2023 14:50:06 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE564B746 for ; Tue, 24 Jan 2023 11:49:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674589763; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=R85STr6GIhhr+ztwclj6pO6G7kZRrikgcAMPHnfe248=; b=M06EbvZzOFrrtsl6DJguwoL9RZYMvOML/vOPBLNCmhrDd+b1mbdcftNFr+F3rTpWoq9206 ySKqVQc+AwJ2mGbj9RlEqGDkpQWeiU4JmU8fLK5ftVJ7PvGWXwwBbK/Ji0CvMjJ8qr2F1m jCMoqPEKPV7USmZNwcidl/OTsme3vWw= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-149-sXn6Q04zOm-Wyc-9oKI0eQ-1; Tue, 24 Jan 2023 14:49:21 -0500 X-MC-Unique: sXn6Q04zOm-Wyc-9oKI0eQ-1 Received: by mail-qk1-f199.google.com with SMTP id de37-20020a05620a372500b00707391077b4so11698049qkb.17 for ; Tue, 24 Jan 2023 11:49:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=R85STr6GIhhr+ztwclj6pO6G7kZRrikgcAMPHnfe248=; b=x2FaEU4EH0cXVl2087nMG0XcW+dIxUns3YbJSBJriNqVgar9PEVqheXg2F8KIIwFLU LNbsEH9c14ASLs0u+MvFWNb8EkH+GLhP15qbKv2CpxXGn8aiAtbX86p6bH17DC9I2FVi 9gV8N3DqC+sxiIexZbpcqHPTEEWrJglnTDDMGjfnPCdD0e8x1ym0Q0Zn97tg5OqVvGsQ OQlpTMkGjil6hr/dN0B9MdmbuAALVPfBY+dmYpLaWv5EmOftaYdYtSes6EsRAowQ+pEB +iuV3PBmQlDEKbro9kmT+/qAeFQQE2y5yKYDjI8ZQlhq/IJtvcdNlIahBTdOqE0F4GVk SpAg== X-Gm-Message-State: AFqh2kqL3HR97hbJV6lo/uy+Ibwg1dvszL9YlZ7tZ+4M6Yr2wUr+e456 U7VWZK/0jAGQv6qj6/mAEeTz7BsRw8JaI6h/iC5SEIz6KGi3JSWDAzSdlt2ncfNoxBX9wE0lZ0D FqDbhTsvkMbhG1TJry7fcbUTO0g== X-Received: by 2002:ac8:4758:0:b0:3b6:36a0:adbe with SMTP id k24-20020ac84758000000b003b636a0adbemr40222113qtp.6.1674589761215; Tue, 24 Jan 2023 11:49:21 -0800 (PST) X-Google-Smtp-Source: AMrXdXu1WuGrk9av6WUp2+OZodLHrIX79DJLQmWseM2cM1QbiDQQOkRVcd+zhy6zkWOiNmjgkRdG5Q== X-Received: by 2002:ac8:4758:0:b0:3b6:36a0:adbe with SMTP id k24-20020ac84758000000b003b636a0adbemr40222080qtp.6.1674589760880; Tue, 24 Jan 2023 11:49:20 -0800 (PST) Received: from x1n (bras-base-aurron9127w-grc-56-70-30-145-63.dsl.bell.ca. [70.30.145.63]) by smtp.gmail.com with ESMTPSA id x12-20020ac87ecc000000b0039cc0fbdb61sm1789700qtj.53.2023.01.24.11.49.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Jan 2023 11:49:20 -0800 (PST) Date: Tue, 24 Jan 2023 14:49:18 -0500 From: Peter Xu To: Muhammad Usama Anjum Cc: Andrei Vagin , Danylo Mocherniuk , David Hildenbrand , Andrew Morton , =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Paul Gofman , Cyrill Gorcunov , Alexander Viro , Shuah Khan , Christian Brauner , Yang Shi , Vlastimil Babka , "Liam R . Howlett" , Yun Zhou , Suren Baghdasaryan , Alex Sierra , Matthew Wilcox , Pasha Tatashin , Mike Rapoport , Nadav Amit , Axel Rasmussen , "Gustavo A . R . Silva" , Dan Williams , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Greg KH , kernel@collabora.com Subject: Re: [PATCH v7 0/4] Implement IOCTL to get and/or the clear info about PTEs Message-ID: References: <20230109064519.3555250-1-usama.anjum@collabora.com> <0eb79bb3-7384-11c6-a380-c027f09305f2@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <0eb79bb3-7384-11c6-a380-c027f09305f2@collabora.com> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, Jan 23, 2023 at 06:15:00PM +0500, Muhammad Usama Anjum wrote: > > Firstly, doc update is more than welcomed to explain the new interface > > first (before throwing the code..). That can be done in pagemap.rst on > > pagemap changes, or userfaultfd.rst on userfaultfd. > Okay. I'll add the documentation in next version or after the series has > been accepted. Initially I'd added the documentation. But the code kept on > changing so much that I had to spend considerable time on updating the > documentation. I know it is better to add documentation with the patches. > I'll try to add it. Yes, logically it should be the thing people start looking with. It'll help reviewers to understand how does it work in general if relevant description is not in the cover letter, so it can matter even before the series is merged. > > There're four kinds of masks (required/anyof/excluded/return). Are they > > all needed? Why this is a good interface design? > Then, CRIU developers Andrea [1] and Danylo [2], asked to include all these > different kinds of masks. I'd thought of these masks as fancy filter inside > the kernel. But there wasn't anyone else to review. So I'd included them to > move forward. Please let me know your thoughts after reading emails from [1]. The idea makes sense to me, thanks. I just hope "moving it forward" is not the only reason that you included it. Please also consider to attach relevant links to your next cover letter so new reviewers can be aware of why the interface is proposed like that. IMHO it would be also great if the CRIU people can acknowledge the interface at some point to make sure it satisfies the needs. An POC would be even better on CRIU, but maybe that's asking too much. -- Peter Xu