From: Dan Carpenter <dan.carpenter@oracle.com>
To: christian.brauner@ubuntu.com
Cc: linux-fsdevel@vger.kernel.org, lkp@intel.com, kbuild@lists.01.org
Subject: [bug report] attr: handle idmapped mounts
Date: Thu, 28 Jan 2021 14:21:02 +0300 [thread overview]
Message-ID: <YBKeHne9FZ42mich@mwanda> (raw)
Hello Christian Brauner,
The patch 2f221d6f7b88: "attr: handle idmapped mounts" from Jan 21,
2021, leads to the following static checker warning:
fs/attr.c:129 setattr_prepare()
warn: inconsistent indenting
fs/attr.c
124 /* Make sure a caller can chmod. */
125 if (ia_valid & ATTR_MODE) {
126 if (!inode_owner_or_capable(mnt_userns, inode))
127 return -EPERM;
128 /* Also check the setgid bit! */
129 if (!in_group_p((ia_valid & ATTR_GID) ? attr->ia_gid :
^^^^^^^^^^^^^^^^^
The patch accidentally swapped tabs for spaces.
The kbuild-bot is supposed to warn about these, but I searched on the
lore.kernel.org thread and didn't see a warning.
https://lore.kernel.org/containers/20210121131959.646623-8-christian.brauner@ubuntu.com/
Presumably it is coming soon.
130 i_gid_into_mnt(mnt_userns, inode)) &&
131 !capable_wrt_inode_uidgid(mnt_userns, inode, CAP_FSETID))
132 attr->ia_mode &= ~S_ISGID;
133 }
regards,
dan carpenter
next reply other threads:[~2021-01-28 11:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 11:21 Dan Carpenter [this message]
2021-01-28 11:31 ` [whitespace] attr: handle idmapped mounts Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YBKeHne9FZ42mich@mwanda \
--to=dan.carpenter@oracle.com \
--cc=christian.brauner@ubuntu.com \
--cc=kbuild@lists.01.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).