From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 876C7C433E1 for ; Mon, 22 Mar 2021 09:27:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3F3BA61972 for ; Mon, 22 Mar 2021 09:27:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229951AbhCVJ1N (ORCPT ); Mon, 22 Mar 2021 05:27:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229920AbhCVJ0m (ORCPT ); Mon, 22 Mar 2021 05:26:42 -0400 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D792C061756 for ; Mon, 22 Mar 2021 02:26:41 -0700 (PDT) Received: by mail-pj1-x1029.google.com with SMTP id mz6-20020a17090b3786b02900c16cb41d63so8194052pjb.2 for ; Mon, 22 Mar 2021 02:26:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=j6MQYdgV4+wrTyHhu2dfzLl8kL+VrmbYPGbkoPs/QS8=; b=diQyqW5ujUZUblbt4D/7jo9LBNUMguG/HQqovdtOTW5/q+hkldXGSyg+FkHbv01hyy pUndIPR3X/gJ3G/x8gM0LA/D2ePJo2eb3QW6+pkYkNCtdfxqQX7KuGb2YNsSJqf5x6sv 21L0K+LjYZvr9lCqfiLvM0CYvifCgk+G4PIXo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=j6MQYdgV4+wrTyHhu2dfzLl8kL+VrmbYPGbkoPs/QS8=; b=Yk07/UYZPijolZyd11YWBxC/go8c3Xk8bB6Lz9zO4nbikDjtuXYV2wPPfEVTlKABY6 Xv7JAgu8L2Is2TdkyaoIZRF9DNCNHEBz/TjtJdJB+9y3colBtKc4gMe0gr+kyosaUdoE 4oGFapI/twl2VHlk/qERmULpBMjEbC3JNBL5FH21ouKwXPULS++QQ8Rxe9SL1KtHheoQ RBsez7cgvFzGfpGP2NAUrg4sd5SedF//Rj4Jc17z5BJpBc6NJtmyUBR1I6AnWytot4jQ CrgCbf3GfHb4nu514Bn3g1PJmQHUAMYu0hkloIYc1T1GAWYUP+nYbsxVX/UF3223BMan p67A== X-Gm-Message-State: AOAM5308F6tMUSgNs5utljftn2+sUw4WL8j02y4nhjFQjvoD8RTTqEje 8MQ8pNj0SFzPmqMZ67cNtw2OEQ== X-Google-Smtp-Source: ABdhPJy+c1RRte8KJzydWERQtlrVDreSmQJ8y8cuu6lFGFvXDdmgRUBmxUwiwQ0qSUtwvjRUqfv/1A== X-Received: by 2002:a17:90a:5898:: with SMTP id j24mr12508922pji.103.1616405200556; Mon, 22 Mar 2021 02:26:40 -0700 (PDT) Received: from google.com ([2409:10:2e40:5100:b1b5:270:5df6:6d6e]) by smtp.gmail.com with ESMTPSA id v25sm13197661pfn.51.2021.03.22.02.26.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Mar 2021 02:26:40 -0700 (PDT) Date: Mon, 22 Mar 2021 18:26:33 +0900 From: Sergey Senozhatsky To: Al Viro Cc: Namjae Jeon , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-cifs@vger.kernel.org, linux-cifsd-devel@lists.sourceforge.net, smfrench@gmail.com, senozhatsky@chromium.org, hyc.lee@gmail.com, hch@lst.de, hch@infradead.org, ronniesahlberg@gmail.com, aurelien.aptel@gmail.com, aaptel@suse.com, sandeen@sandeen.net, dan.carpenter@oracle.com, colin.king@canonical.com, rdunlap@infradead.org, Sergey Senozhatsky , Steve French Subject: Re: [PATCH 3/5] cifsd: add file operations Message-ID: References: <20210322051344.1706-1-namjae.jeon@samsung.com> <20210322051344.1706-4-namjae.jeon@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On (21/03/22 07:02), Al Viro wrote: > On Mon, Mar 22, 2021 at 02:13:42PM +0900, Namjae Jeon wrote: > > +static struct ksmbd_file *__ksmbd_lookup_fd(struct ksmbd_file_table *ft, > > + unsigned int id) > > +{ > > + bool unclaimed = true; > > + struct ksmbd_file *fp; > > + > > + read_lock(&ft->lock); > > + fp = idr_find(ft->idr, id); > > + if (fp) > > + fp = ksmbd_fp_get(fp); > > + > > + if (fp && fp->f_ci) { > > + read_lock(&fp->f_ci->m_lock); > > + unclaimed = list_empty(&fp->node); > > + read_unlock(&fp->f_ci->m_lock); > > + } > > + read_unlock(&ft->lock); > > + > > + if (fp && unclaimed) { > > + atomic_dec(&fp->refcount); > > + return NULL; > > + } > > Can that atomic_dec() end up dropping the last remaining reference? Yes, I think it should increment refcount only for "claimed" fp.