From: Stefan Hajnoczi <stefanha@redhat.com>
To: Connor Kuehl <ckuehl@redhat.com>
Cc: virtio-fs@redhat.com, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Miklos Szeredi <miklos@szeredi.hu>,
Vivek Goyal <vgoyal@redhat.com>
Subject: Re: [PATCH] virtiofs: Enable multiple request queues
Date: Tue, 11 May 2021 11:23:12 +0100 [thread overview]
Message-ID: <YJpbEMePhQ88EWWR@stefanha-x1.localdomain> (raw)
In-Reply-To: <20210507221527.699516-1-ckuehl@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 470 bytes --]
On Fri, May 07, 2021 at 05:15:27PM -0500, Connor Kuehl wrote:
> @@ -1245,7 +1262,8 @@ __releases(fiq->lock)
> req->in.h.nodeid, req->in.h.len,
> fuse_len_args(req->args->out_numargs, req->args->out_args));
>
> - fsvq = &fs->vqs[queue_id];
> + fsvq = this_cpu_read(this_cpu_fsvq);
Please check how CPU hotplug affects this patch. If the current CPU
doesn't have a vq because it was hotplugged, then it may be necessary to
pick another vq.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-05-11 10:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-07 22:15 [PATCH] virtiofs: Enable multiple request queues Connor Kuehl
2021-05-08 1:19 ` kernel test robot
2021-05-08 12:22 ` Connor Kuehl
2021-05-10 15:25 ` Vivek Goyal
2021-05-10 16:15 ` Connor Kuehl
2021-05-10 17:50 ` Vivek Goyal
2021-05-11 10:23 ` Stefan Hajnoczi [this message]
2021-05-11 14:41 ` Connor Kuehl
-- strict thread matches above, loose matches on Subject: below --
2022-12-11 10:38 [PATCH] virtiofs: enable " Jiachen Zhang
2022-12-11 11:01 ` Jiachen Zhang
2022-12-11 19:09 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJpbEMePhQ88EWWR@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=ckuehl@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=vgoyal@redhat.com \
--cc=virtio-fs@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).