From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56B6EC47082 for ; Thu, 3 Jun 2021 21:57:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3519561401 for ; Thu, 3 Jun 2021 21:57:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230200AbhFCV7a (ORCPT ); Thu, 3 Jun 2021 17:59:30 -0400 Received: from mail-pl1-f182.google.com ([209.85.214.182]:38694 "EHLO mail-pl1-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230083AbhFCV7a (ORCPT ); Thu, 3 Jun 2021 17:59:30 -0400 Received: by mail-pl1-f182.google.com with SMTP id 69so3604690plc.5 for ; Thu, 03 Jun 2021 14:57:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=hcR2WT3vvryIaxbYCFHgFPNRMu872lwm697WZRE1kh8=; b=OJ1ffKBL2zTMCQ8FGoFYNEK/qKuYsaHaSFwj3Gi0UxE+Hu2kehZOW8OHbO6bSbfsx3 gY3bdb8N37tXlvSuJWR5rjzrdziyY5EMf8D5Q1IeQQvxH4n4xLAvy1/Us8AY20mDPv09 7LAH6KrYzOhMGVDh+4KeGEVveCicvz6ZvjTLSFz5eumGHGfsmDZpq5WbgVoyFdMRMdJS Cwd3rF5kgbCzax+t70gJYwHOq8NtnD1BueaqiRgxjsNA5VFEugbrVG0iWv37sd/SaENB RdNy3EEN1r+BfOPygMbxtCjMY7R1yDwLGKkuq9KBtGvm28a44ADIcMMMVYno/vIgQtkA bayA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=hcR2WT3vvryIaxbYCFHgFPNRMu872lwm697WZRE1kh8=; b=Vtgn2tSrBdtHkeEjEdbnyWhEgzOLT3xHTz7o1RoCV5s+RFNchfbk7DYCa2RqbDLm10 nRRqugoHMfUzzgrBAyMzZTKTfOj1eNtU3hPJHsWCd6VrgilJsRrlwBL9pL3R5aJv/LPk O5SR04adKMvHrd4AaturEwgmlXPG4/ehGH48WPoAEbV0gQuyfNvuAJ30TN7XxPcXOuxC sVgvpf92k8X9WJ7jk77VbLgjLxW2mYZH0fFOsyduA8FGTgcRrP3hw9FKQzlhnFTRBZ4y rMjKIC8PrYgEp6PVoPNb+hzLd/1aSBp+/nmrpyVdJetJwzs8QeBo9CzuaPhl5QFpFGFc eG4g== X-Gm-Message-State: AOAM531pg+Elkvi4HuMpVZain811FxrBF5WPSwtcRai12lJsbPdESo3u zWGgrhWBBgSuT1RRf8DlsPFGQw== X-Google-Smtp-Source: ABdhPJyVUWstFctTJ2cBSzd8UOkLP8piwEWGOeyh98T/MvRNyuOqD1X92kpZG8zfPPjYlXoXiXFMqg== X-Received: by 2002:a17:90a:7e92:: with SMTP id j18mr1384538pjl.231.1622757392443; Thu, 03 Jun 2021 14:56:32 -0700 (PDT) Received: from google.com ([2401:fa00:9:211:6fff:8119:dab5:49cd]) by smtp.gmail.com with ESMTPSA id x13sm3519123pja.3.2021.06.03.14.56.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Jun 2021 14:56:31 -0700 (PDT) Date: Fri, 4 Jun 2021 07:56:18 +1000 From: Matthew Bobrowski To: Jan Kara Cc: Amir Goldstein , kernel test robot , Christian Brauner , LKML , lkp@lists.01.org, kbuild test robot , ying.huang@intel.com, feng.tang@intel.com, zhengjun.xing@linux.intel.com, linux-fsdevel Subject: Re: [fanotify] a8b98c808e: stress-ng.fanotify.ops_per_sec 32.2% improvement Message-ID: References: <20210603015314.GA21290@xsang-OptiPlex-9020> <20210603084324.GC23647@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210603084324.GC23647@quack2.suse.cz> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Jun 03, 2021 at 10:43:24AM +0200, Jan Kara wrote: > On Thu 03-06-21 09:57:15, Amir Goldstein wrote: > > On Thu, Jun 3, 2021 at 4:36 AM kernel test robot wro > > > Greeting, > > > > > > FYI, we noticed a 32.2% improvement of stress-ng.fanotify.ops_per_sec due to commit: > > > > > > > > > commit: a8b98c808eab3ec8f1b5a64be967b0f4af4cae43 ("fanotify: fix permission model of unprivileged group") > > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master > > > > > > > > > > I guess now we know what caused the reported regression: > > https://lore.kernel.org/lkml/20210511124632.GL24154@quack2.suse.cz/ > > > > I didn't know that capable() is so significant. > > Yeah, I wouldn't guess either. Interesting. Indeed, interesting! :) While on the topic of stress-ng, it reminds me to set this up on my server so we can perform such regressions before merging fanotify changes into master. /M