* Re: [fanotify] a8b98c808e: stress-ng.fanotify.ops_per_sec 32.2% improvement [not found] <20210603015314.GA21290@xsang-OptiPlex-9020> @ 2021-06-03 6:57 ` Amir Goldstein 2021-06-03 8:43 ` Jan Kara 0 siblings, 1 reply; 3+ messages in thread From: Amir Goldstein @ 2021-06-03 6:57 UTC (permalink / raw) To: kernel test robot Cc: Jan Kara, Matthew Bobrowski, Christian Brauner, LKML, lkp, kbuild test robot, ying.huang, feng.tang, zhengjun.xing, linux-fsdevel On Thu, Jun 3, 2021 at 4:36 AM kernel test robot <oliver.sang@intel.com> wrote: > > > > Greeting, > > FYI, we noticed a 32.2% improvement of stress-ng.fanotify.ops_per_sec due to commit: > > > commit: a8b98c808eab3ec8f1b5a64be967b0f4af4cae43 ("fanotify: fix permission model of unprivileged group") > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master > > I guess now we know what caused the reported regression: https://lore.kernel.org/lkml/20210511124632.GL24154@quack2.suse.cz/ I didn't know that capable() is so significant. FWIW, here is a link to the test code: https://github.com/ColinIanKing/stress-ng/blob/master/stress-fanotify.c#L474 It creates events in a loop by child process while the parent process reads the generated events in a loop (on two different fanotify groups). Thanks, Amir. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [fanotify] a8b98c808e: stress-ng.fanotify.ops_per_sec 32.2% improvement 2021-06-03 6:57 ` [fanotify] a8b98c808e: stress-ng.fanotify.ops_per_sec 32.2% improvement Amir Goldstein @ 2021-06-03 8:43 ` Jan Kara 2021-06-03 21:56 ` Matthew Bobrowski 0 siblings, 1 reply; 3+ messages in thread From: Jan Kara @ 2021-06-03 8:43 UTC (permalink / raw) To: Amir Goldstein Cc: kernel test robot, Jan Kara, Matthew Bobrowski, Christian Brauner, LKML, lkp, kbuild test robot, ying.huang, feng.tang, zhengjun.xing, linux-fsdevel On Thu 03-06-21 09:57:15, Amir Goldstein wrote: > On Thu, Jun 3, 2021 at 4:36 AM kernel test robot <oliver.sang@intel.com> wrote: > > > > > > > > Greeting, > > > > FYI, we noticed a 32.2% improvement of stress-ng.fanotify.ops_per_sec due to commit: > > > > > > commit: a8b98c808eab3ec8f1b5a64be967b0f4af4cae43 ("fanotify: fix permission model of unprivileged group") > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master > > > > > > I guess now we know what caused the reported regression: > https://lore.kernel.org/lkml/20210511124632.GL24154@quack2.suse.cz/ > > I didn't know that capable() is so significant. Yeah, I wouldn't guess either. Interesting. Honza -- Jan Kara <jack@suse.com> SUSE Labs, CR ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [fanotify] a8b98c808e: stress-ng.fanotify.ops_per_sec 32.2% improvement 2021-06-03 8:43 ` Jan Kara @ 2021-06-03 21:56 ` Matthew Bobrowski 0 siblings, 0 replies; 3+ messages in thread From: Matthew Bobrowski @ 2021-06-03 21:56 UTC (permalink / raw) To: Jan Kara Cc: Amir Goldstein, kernel test robot, Christian Brauner, LKML, lkp, kbuild test robot, ying.huang, feng.tang, zhengjun.xing, linux-fsdevel On Thu, Jun 03, 2021 at 10:43:24AM +0200, Jan Kara wrote: > On Thu 03-06-21 09:57:15, Amir Goldstein wrote: > > On Thu, Jun 3, 2021 at 4:36 AM kernel test robot <oliver.sang@intel.com> wro > > > Greeting, > > > > > > FYI, we noticed a 32.2% improvement of stress-ng.fanotify.ops_per_sec due to commit: > > > > > > > > > commit: a8b98c808eab3ec8f1b5a64be967b0f4af4cae43 ("fanotify: fix permission model of unprivileged group") > > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master > > > > > > > > > > I guess now we know what caused the reported regression: > > https://lore.kernel.org/lkml/20210511124632.GL24154@quack2.suse.cz/ > > > > I didn't know that capable() is so significant. > > Yeah, I wouldn't guess either. Interesting. Indeed, interesting! :) While on the topic of stress-ng, it reminds me to set this up on my server so we can perform such regressions before merging fanotify changes into master. /M ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-03 21:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20210603015314.GA21290@xsang-OptiPlex-9020>
2021-06-03 6:57 ` [fanotify] a8b98c808e: stress-ng.fanotify.ops_per_sec 32.2% improvement Amir Goldstein
2021-06-03 8:43 ` Jan Kara
2021-06-03 21:56 ` Matthew Bobrowski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).