From: Christoph Hellwig <hch@infradead.org>
To: Josef Bacik <josef@toxicpanda.com>
Cc: linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
kernel-team@fb.com
Subject: Re: [PATCH 6/6] btrfs: use the filemap_fdatawrite_wbc helper for delalloc shrinking
Date: Mon, 28 Jun 2021 17:50:27 +0100 [thread overview]
Message-ID: <YNn90xi1imSwCDr/@infradead.org> (raw)
In-Reply-To: <2acb56dd851d31d7b5547099821f0cbf6dfb5d29.1624894102.git.josef@toxicpanda.com>
On Mon, Jun 28, 2021 at 11:37:11AM -0400, Josef Bacik wrote:
> sync_inode() has some holes that can cause problems if we're under heavy
> ENOSPC pressure. If there's writeback running on a separate thread
> sync_inode() will skip writing the inode altogether. What we really
> want is to make sure writeback has been started on all the pages to make
> sure we can see the ordered extents and wait on them if appropriate.
> Switch to this new helper which will allow us to accomplish this and
> avoid ENOSPC'ing early.
The only other exported user of sync_inode is in btrfs as well. What
is the difference vs this caller? Mostly I'd like to kill sync_inode
to reduce the surface of different hooks into the writeback code, and
for something externally callable your new filemap_fdatawrite_wbc
helpers looks nassively preferable of sync_inode /
writeback_single_inode.
next prev parent reply other threads:[~2021-06-28 16:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 15:37 [PATCH 0/6] ENOSPC delalloc flushing fixes Josef Bacik
2021-06-28 15:37 ` [PATCH 1/6] btrfs: enable a tracepoint when we fail tickets Josef Bacik
2021-06-28 15:37 ` [PATCH 2/6] btrfs: handle shrink_delalloc pages calculation differently Josef Bacik
2021-06-28 15:37 ` [PATCH 3/6] btrfs: wait on async extents when flushing delalloc Josef Bacik
2021-06-28 15:37 ` [PATCH 4/6] btrfs: wake up async_delalloc_pages waiters after submit Josef Bacik
2021-06-28 15:37 ` [PATCH 5/6] fs: add a filemap_fdatawrite_wbc helper Josef Bacik
2021-06-28 15:37 ` [PATCH 6/6] btrfs: use the filemap_fdatawrite_wbc helper for delalloc shrinking Josef Bacik
2021-06-28 16:50 ` Christoph Hellwig [this message]
2021-06-28 18:13 ` Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNn90xi1imSwCDr/@infradead.org \
--to=hch@infradead.org \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).