From: Matthew Wilcox <willy@infradead.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Andreas Gruenbacher <agruenba@redhat.com>,
"Darrick J . Wong" <djwong@kernel.org>,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
cluster-devel@redhat.com
Subject: Re: [PATCH 0/2] iomap: small block problems
Date: Mon, 28 Jun 2021 22:59:55 +0100 [thread overview]
Message-ID: <YNpGW2KNMF9f77bk@casper.infradead.org> (raw)
In-Reply-To: <YNoLTl602RrckQND@infradead.org>
On Mon, Jun 28, 2021 at 06:47:58PM +0100, Christoph Hellwig wrote:
> On Mon, Jun 28, 2021 at 06:39:09PM +0100, Matthew Wilcox wrote:
> > Not hugely happy with either of these options, tbh. I'd rather we apply
> > a patch akin to this one (plucked from the folio tree), so won't apply:
>
> > so permit pages without an iop to enter writeback and create an iop
> > *then*. Would that solve your problem?
>
> It is the right thing to do, especially when combined with a feature
> patch to not bother to create the iomap_page structure on small
> block size file systems when the extent covers the whole page.
We don't know the extent layout at the point where *this* patch creates
iomap_pages during writeback. I imagine we can delay creating one until
we find out what our destination layout will be?
next prev parent reply other threads:[~2021-06-28 22:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 17:27 [PATCH 0/2] iomap: small block problems Andreas Gruenbacher
2021-06-28 17:27 ` [PATCH 1/2] iomap: Don't create iomap_page objects for inline files Andreas Gruenbacher
2021-06-30 13:35 ` Matthew Wilcox
2021-06-28 17:27 ` [PATCH 2/2] iomap: Add helper for un-inlining an inline inode Andreas Gruenbacher
2021-06-28 17:39 ` [PATCH 0/2] iomap: small block problems Matthew Wilcox
2021-06-28 17:47 ` Christoph Hellwig
2021-06-28 21:28 ` Andreas Gruenbacher
2021-06-28 21:59 ` Matthew Wilcox [this message]
2021-06-29 5:29 ` Christoph Hellwig
2021-06-29 5:42 ` Christoph Hellwig
2021-06-30 12:29 ` Andreas Gruenbacher
2021-07-05 15:51 ` Andreas Gruenbacher
2021-07-05 16:55 ` Christoph Hellwig
2021-06-28 17:55 ` Andreas Gruenbacher
2021-06-29 9:12 ` Andreas Gruenbacher
2021-06-30 14:08 ` Matthew Wilcox
2021-06-30 14:45 ` Andreas Gruenbacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNpGW2KNMF9f77bk@casper.infradead.org \
--to=willy@infradead.org \
--cc=agruenba@redhat.com \
--cc=cluster-devel@redhat.com \
--cc=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).