From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB1F0C11F69 for ; Wed, 30 Jun 2021 13:37:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D236E613DB for ; Wed, 30 Jun 2021 13:37:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234768AbhF3Njk (ORCPT ); Wed, 30 Jun 2021 09:39:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234931AbhF3Njk (ORCPT ); Wed, 30 Jun 2021 09:39:40 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F7A9C061756; Wed, 30 Jun 2021 06:37:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=fwxAe5Jj4nUADGQ3NnZuU6s3gb4g0NHrvfY343FArro=; b=wBXbhN9bolWpPd/0O5AcbOMwl3 eH8G40RWYk4EUOxl/3O2HuBFmrrDBoEhAuVeXobOqWw31yzwJOblUvyB03dh7LD4GLsoaBtJN9bem cpxNzqOFizQLTuXo1imD3hGoXBsUn3ddnjKbWPIv6Xvg3WXnUXeq60KAs66jLf2sJ/UzlFm441ikP 1eXps7onJv/674Bylhe3cT7Mq1hYSFbdyW274t29dWyBjSK3W0CZO4og5VtcGJKPh7atOr7Yoy/Iw 6cv2kzihbRl6XCCbossxXRTPMs8fH/sFLdqefVE/B2fKOryj3BVjZnJ2s2ByCPWK3OPaAucb2iSRy COoYedcg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1lyaNe-005OGB-1L; Wed, 30 Jun 2021 13:36:02 +0000 Date: Wed, 30 Jun 2021 14:35:54 +0100 From: Matthew Wilcox To: Andreas Gruenbacher Cc: Christoph Hellwig , "Darrick J . Wong" , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, cluster-devel@redhat.com Subject: Re: [PATCH 1/2] iomap: Don't create iomap_page objects for inline files Message-ID: References: <20210628172727.1894503-1-agruenba@redhat.com> <20210628172727.1894503-2-agruenba@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210628172727.1894503-2-agruenba@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, Jun 28, 2021 at 07:27:26PM +0200, Andreas Gruenbacher wrote: > In iomap_readpage_actor, don't create iop objects for inline inodes. > Otherwise, iomap_read_inline_data will set PageUptodate without setting > iop->uptodate, and iomap_page_release will eventually complain. > > To prevent this kind of bug from occurring in the future, make sure the > page doesn't have private data attached in iomap_read_inline_data. > > Signed-off-by: Andreas Gruenbacher Reviewed-by: Matthew Wilcox (Oracle)