From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D102DC07E95 for ; Tue, 13 Jul 2021 13:02:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B826F60240 for ; Tue, 13 Jul 2021 13:02:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236450AbhGMNF1 (ORCPT ); Tue, 13 Jul 2021 09:05:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236276AbhGMNF1 (ORCPT ); Tue, 13 Jul 2021 09:05:27 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 529BCC0613DD; Tue, 13 Jul 2021 06:02:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=QTFWZ70fPTxxGEfvpW72iHrISZ3ROumWvX7+BCwkJ0E=; b=WpZY2MwAsMub0Dpyaxn+R4FRAo WgnNZJlWVxz5235Wc62HNNBkKgC0R28TaOahiPk8q/dWIx3h1KiplTIONREJFaRDQdKs+aGRZyoNu OU9h3YiS2XtS0Cv3S2EGJBjoM3MeKEpXZ9D+NpUz/h0VN/80t1ai8S3AspZs2LXny6NITrT97g+T6 SSsoraYw1DjXzAZ1fCNugbAbMVv7HTIU1NNDptus1BhndrabfeUR6OxcjAbyTDxK+nAqvmleK+Q+2 TZdxfMhdz5W0KEQFS2WWI1Yb6EIHkMo1pt81H0JCYZBr3EaKfFf5fTqlWWBQS3i5OUfVhz9CCFwPC PHSeeC4Q==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3I32-0017Jd-Rs; Tue, 13 Jul 2021 13:02:10 +0000 Date: Tue, 13 Jul 2021 14:02:04 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, cgroups@vger.kernel.org Subject: Re: [PATCH v13 15/18] mm/memcg: Add folio_lruvec() Message-ID: References: <20210712194551.91920-1-willy@infradead.org> <20210712194551.91920-16-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210712194551.91920-16-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, Jul 12, 2021 at 08:45:48PM +0100, Matthew Wilcox (Oracle) wrote: > This replaces mem_cgroup_page_lruvec(). All callers converted. Looks good, especially as it doesn't have much to do with cgroups except as an implementation detail. Shouldn't this function also move out of memcontrol.h eventually? Reviewed-by: Christoph Hellwig