From: Matthew Bobrowski <repnop@google.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Jan Kara <jack@suse.cz>, linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: FAN_REPORT_CHILD_FID
Date: Wed, 14 Jul 2021 11:16:38 +1000 [thread overview]
Message-ID: <YO469q9T7h0LBlIT@google.com> (raw)
In-Reply-To: <CAOQ4uxgHeX3r4eJ=4OgksDnkddPqOs0a8JxP5VDFjEddmRcorA@mail.gmail.com>
On Mon, Jul 12, 2021 at 09:08:18PM +0300, Amir Goldstein wrote:
> On Mon, Jul 12, 2021 at 7:26 PM Jan Kara <jack@suse.cz> wrote:
> > On Mon 12-07-21 16:00:54, Amir Goldstein wrote:
> > Just a brainstorming idea: How about creating new event FAN_RENAME that
> > would report two DFIDs (if it is cross directory rename)?
>
> I like the idea, but it would have to be two DFID_NAME is case of
> FAN_REPORT_DFID_NAME and also for same parent rename
> to be consistent.
I don't have much to add to this conversation, but I'm just curious here.
If we do require two separate DFID_NAME record objects in the case of cross
directory rename operations, how does an event listener distinguish the
difference between which is which i.e. moved_{from/to}? To me, this
implies that the event listener is expected to rely on specific
supplemental information object ordering, which to my knowledge is a
contract that we had always wanted to avoid drawing.
/M
next prev parent reply other threads:[~2021-07-14 1:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-11 17:02 FAN_REPORT_CHILD_FID Amir Goldstein
2021-07-12 11:10 ` FAN_REPORT_CHILD_FID Jan Kara
2021-07-12 13:00 ` FAN_REPORT_CHILD_FID Amir Goldstein
2021-07-12 16:26 ` FAN_REPORT_CHILD_FID Jan Kara
2021-07-12 18:08 ` FAN_REPORT_CHILD_FID Amir Goldstein
2021-07-14 1:16 ` Matthew Bobrowski [this message]
2021-07-14 12:09 ` FAN_REPORT_CHILD_FID Amir Goldstein
2021-07-15 23:53 ` FAN_REPORT_CHILD_FID Matthew Bobrowski
2021-07-16 9:47 ` FAN_REPORT_CHILD_FID Jan Kara
2021-07-16 11:24 ` FAN_REPORT_CHILD_FID Amir Goldstein
2021-07-27 10:44 ` FAN_REPORT_CHILD_FID Amir Goldstein
2021-07-28 9:51 ` FAN_REPORT_CHILD_FID Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YO469q9T7h0LBlIT@google.com \
--to=repnop@google.com \
--cc=amir73il@gmail.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).