From: Christoph Hellwig <hch@infradead.org>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
"Darrick J . Wong" <djwong@kernel.org>,
Matthew Wilcox <willy@infradead.org>,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
cluster-devel@redhat.com
Subject: Re: [PATCH v2 1/2] iomap: Don't create iomap_page objects for inline files
Date: Tue, 6 Jul 2021 06:03:50 +0100 [thread overview]
Message-ID: <YOPkNnQ34vRiVYs6@infradead.org> (raw)
In-Reply-To: <20210705181824.2174165-2-agruenba@redhat.com>
On Mon, Jul 05, 2021 at 08:18:23PM +0200, Andreas Gruenbacher wrote:
> In iomap_readpage_actor, don't create iop objects for inline inodes.
> Otherwise, iomap_read_inline_data will set PageUptodate without setting
> iop->uptodate, and iomap_page_release will eventually complain.
>
> To prevent this kind of bug from occurring in the future, make sure the
> page doesn't have private data attached in iomap_read_inline_data.
>
> Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
> Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
As mentioned last round I'd prefer to simply not create the iomap_page
at all in the readpage/readpages path.
Also this patch needs to go after the current patch 2 to be bisection
clean.
next prev parent reply other threads:[~2021-07-06 5:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-05 18:18 [PATCH v2 0/2] iomap: small block problems Andreas Gruenbacher
2021-07-05 18:18 ` [PATCH v2 1/2] iomap: Don't create iomap_page objects for inline files Andreas Gruenbacher
2021-07-06 5:03 ` Christoph Hellwig [this message]
2021-07-06 16:01 ` Andreas Gruenbacher
2021-07-05 18:18 ` [PATCH v2 2/2] iomap: Permit pages without an iop to enter writeback Andreas Gruenbacher
2021-07-06 5:04 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOPkNnQ34vRiVYs6@infradead.org \
--to=hch@infradead.org \
--cc=agruenba@redhat.com \
--cc=cluster-devel@redhat.com \
--cc=djwong@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).