From: Matthew Bobrowski <repnop@google.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Jan Kara <jack@suse.cz>,
Matthew Bobrowski <mbobrowski@mbobrowski.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/4] fsnotify: replace igrab() with ihold() on attach connector
Date: Tue, 10 Aug 2021 15:39:26 +1000 [thread overview]
Message-ID: <YRIRDgAbya4GQ0bc@google.com> (raw)
In-Reply-To: <20210803180344.2398374-2-amir73il@gmail.com>
On Tue, Aug 03, 2021 at 09:03:41PM +0300, Amir Goldstein wrote:
> We must have a reference on inode, so ihold is cheaper.
>
> Signed-off-by: Amir Goldstein <amir73il@gmail.com>
LGTM.
Reviewed-by: Matthew Bobrowski <repnop@google.com>
> ---
> fs/notify/mark.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/fs/notify/mark.c b/fs/notify/mark.c
> index d32ab349db74..80459db58f63 100644
> --- a/fs/notify/mark.c
> +++ b/fs/notify/mark.c
> @@ -493,8 +493,11 @@ static int fsnotify_attach_connector_to_object(fsnotify_connp_t *connp,
> conn->fsid.val[0] = conn->fsid.val[1] = 0;
> conn->flags = 0;
> }
> - if (conn->type == FSNOTIFY_OBJ_TYPE_INODE)
> - inode = igrab(fsnotify_conn_inode(conn));
> + if (conn->type == FSNOTIFY_OBJ_TYPE_INODE) {
> + inode = fsnotify_conn_inode(conn);
> + ihold(inode);
> + }
> +
> /*
> * cmpxchg() provides the barrier so that readers of *connp can see
> * only initialized structure
> --
> 2.25.1
>
/M
next prev parent reply other threads:[~2021-08-10 5:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-03 18:03 [PATCH 0/4] Performance optimization for no fsnotify marks Amir Goldstein
2021-08-03 18:03 ` [PATCH 1/4] fsnotify: replace igrab() with ihold() on attach connector Amir Goldstein
2021-08-10 5:39 ` Matthew Bobrowski [this message]
2021-08-03 18:03 ` [PATCH 2/4] fsnotify: count s_fsnotify_inode_refs for attached connectors Amir Goldstein
2021-08-10 6:03 ` Matthew Bobrowski
2021-08-03 18:03 ` [PATCH 3/4] fsnotify: count all objects with " Amir Goldstein
2021-08-10 6:31 ` Matthew Bobrowski
2021-08-10 14:12 ` Amir Goldstein
2021-08-10 10:47 ` Jan Kara
2021-08-10 14:22 ` Amir Goldstein
2021-08-03 18:03 ` [PATCH 4/4] fsnotify: optimize the case of no marks of any type Amir Goldstein
2021-08-08 14:34 ` [fsnotify] e902b4cafb: unixbench.score 6.1% improvement kernel test robot
2021-08-10 6:43 ` [PATCH 4/4] fsnotify: optimize the case of no marks of any type Matthew Bobrowski
2021-08-10 10:49 ` [PATCH 0/4] Performance optimization for no fsnotify marks Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRIRDgAbya4GQ0bc@google.com \
--to=repnop@google.com \
--cc=amir73il@gmail.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mbobrowski@mbobrowski.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).