From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93FD4C4338F for ; Fri, 13 Aug 2021 18:57:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6DBC9610CF for ; Fri, 13 Aug 2021 18:57:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230039AbhHMS6D (ORCPT ); Fri, 13 Aug 2021 14:58:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231318AbhHMS6B (ORCPT ); Fri, 13 Aug 2021 14:58:01 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7EBF9C061756; Fri, 13 Aug 2021 11:57:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=n0UYFCDfn/6EPWQxCxZcMRZGDBC1ig7t4FOClsfmIzs=; b=rW+90qbnrmWgb2k22pBJY1LrTl jzfGsbj5b5h/mRwDC/MoMZR4VlwW/j4l/xA93697kYfOtilnQbg1A8oCNMl+DwNUoE+f2S8ilfDTM c+4Vf9+pKxgClznbZg+rZbIkuzaSiE1umQI9mL4cSmVXdQCtDCkni9eJ+DPUBDqa4nq73fmFfPMM4 n3TzbOD58Env3CuCXuPttnqaJwk9CfAtEtCz5/sT7Q1FIkfQh7LanDbrgSqLd1n7cGzkdDXNxtE/4 fqZmvsDdp05jgrn3NawXLYWDrECWlHpXwuIJsGA8FZi9srrakhVtLo80NVIr1ZytvbJn2H6LdH3cJ 3sNjNXHA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mEcMG-00Fz7Y-L1; Fri, 13 Aug 2021 18:56:51 +0000 Date: Fri, 13 Aug 2021 19:56:44 +0100 From: Matthew Wilcox To: David Howells Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Michal Hocko , Johannes Weiner , Christoph Hellwig Subject: Re: [PATCH v14 035/138] mm/memcg: Use the node id in mem_cgroup_update_tree() Message-ID: References: <20210715033704.692967-36-willy@infradead.org> <20210715033704.692967-1-willy@infradead.org> <1809568.1628626012@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1809568.1628626012@warthog.procyon.org.uk> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Aug 10, 2021 at 09:06:52PM +0100, David Howells wrote: > Matthew Wilcox (Oracle) wrote: > > > By using the node id in mem_cgroup_update_tree(), we can delete > > soft_limit_tree_from_page() and mem_cgroup_page_nodeinfo(). Saves 42 > > bytes of kernel text on my config. > > > > Signed-off-by: Matthew Wilcox (Oracle) > > Acked-by: Michal Hocko > > Acked-by: Johannes Weiner > > Reviewed-by: Christoph Hellwig > > Reviewed-by: David Howells > > Though I wonder if: > > > - mz = mem_cgroup_page_nodeinfo(memcg, page); > > + mz = memcg->nodeinfo[nid]; > > should still have some sort of wrapper function. I was asked to remove the wrapper function as it didn't provide enough utility to warrant the indirection.