From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0D4BC4338F for ; Wed, 25 Aug 2021 06:35:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D8CCC613A7 for ; Wed, 25 Aug 2021 06:35:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239001AbhHYGgY (ORCPT ); Wed, 25 Aug 2021 02:36:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239293AbhHYGgW (ORCPT ); Wed, 25 Aug 2021 02:36:22 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2228C061757; Tue, 24 Aug 2021 23:35:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=2XLmr3mig5i7hFsrhfybeAZVxu1dPFwBTiqJmo2ZjDs=; b=Y/vL5A1XzYQGjecTWV5ZlubPWZ GTZIZXOm9XJO0Be7zs+Aj9ueGAGEfnmZxexw/PUD7kF5QYnOLhKGqh6ujtUIll2y3crONRFnfjkGn XEu2lb0XgzN21b5//QSf3Sv9zeguPFet/OyzEGBOr15LkzC0jf9WMzGNFJcV1sbUOfakeh/IJIu0t 4vy3wCYV2ew5sq+yeoArOQi4ZTTkE3L1TxQPPwlnCJztnkkQ/YGQhC9FaGF6hdJlYrGnvNWebM0Ii RTsykyka9MLAs4Hll6kzSOxoIXa7sdJc6rVZLftLKAjjpWr85iqzHgOf5apapcyTgtQ7/qrAkuPm+ 4hrxNGVw==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mImSq-00ByML-7A; Wed, 25 Aug 2021 06:32:54 +0000 Date: Wed, 25 Aug 2021 07:32:44 +0100 From: Christoph Hellwig To: Theodore Ts'o Cc: Matthew Wilcox , Linus Torvalds , David Howells , Johannes Weiner , Linux-MM , linux-fsdevel , Linux Kernel Mailing List , Andrew Morton Subject: Re: [GIT PULL] Memory folios for v5.15 Message-ID: References: <1957060.1629820467@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Aug 24, 2021 at 03:44:48PM -0400, Theodore Ts'o wrote: > The problem is whether we use struct head_page, or folio, or mempages, > we're going to be subsystem users' faces. And people who are using it > every day will eventually get used to anything, whether it's "folio" > or "xmoqax", we sould give a thought to newcomers to Linux file system > code. If they see things like "read_folio()", they are going to be > far more confused than "read_pages()" or "read_mempages()". Are they? It's not like page isn't some randomly made up term as well, just one that had a lot more time to spread. > So if someone sees "kmem_cache_alloc()", they can probably make a > guess what it means, and it's memorable once they learn it. > Similarly, something like "head_page", or "mempages" is going to a bit > more obvious to a kernel newbie. So if we can make a tiny gesture > towards comprehensibility, it would be good to do so while it's still > easier to change the name. All this sounds really weird to me. I doubt there is any name that nicely explains "structure used to manage arbitrary power of two units of memory in the kernel" very well. So I agree with willy here, let's pick something short and not clumsy. I initially found the folio name a little strange, but working with it I got used to it quickly. And all the other uggestions I've seen s far are significantly worse, especially all the odd compounds with page in it.