From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DD0BC4332F for ; Wed, 8 Sep 2021 10:52:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1DC5261167 for ; Wed, 8 Sep 2021 10:52:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348953AbhIHKyD (ORCPT ); Wed, 8 Sep 2021 06:54:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38314 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348884AbhIHKyC (ORCPT ); Wed, 8 Sep 2021 06:54:02 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1D60C061575; Wed, 8 Sep 2021 03:52:54 -0700 (PDT) Received: from zn.tnic (p200300ec2f0efc002d1ac0b1b41b9169.dip0.t-ipconnect.de [IPv6:2003:ec:2f0e:fc00:2d1a:c0b1:b41b:9169]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 823EB1EC0246; Wed, 8 Sep 2021 12:52:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1631098372; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=/c1i7MJmMtvpNZUmYoO8pHyXNL8x7+xg5ZYSPs97nbA=; b=jr+NflkNApcbMcE3x32XD/UX7p/0fqIF65IsSvGVzESGORog8godikPznZVkEHWAEfDZp/ 3cJpFWYdwvZIYVjJoVqIb18N+9kITRR9p/Hy2pBWEoAPDfgBtrObF1m218D0WEFw/Run5F lcaRmegenetKjtMzrdNH5JFrk8D+7M8= Date: Wed, 8 Sep 2021 12:52:45 +0200 From: Borislav Petkov To: Dave Hansen , Mike Rapoport Cc: x86@kernel.org, Andrew Morton , Andy Lutomirski , Dave Hansen , David Hildenbrand , Ingo Molnar , Jiri Olsa , Mike Rapoport , Oscar Salvador , Peter Zijlstra , Thomas Gleixner , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2] x86/mm: fix kern_addr_valid to cope with existing but not present entries Message-ID: References: <20210819132717.19358-1-rppt@kernel.org> <35f4a263-1001-5ba5-7b6c-3fcc5f93cc30@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Sep 08, 2021 at 12:35:21PM +0200, Borislav Petkov wrote: > So I did stare at this for a while, trying to make sense of it and David > Hildenbrand asked for a Fixes: tag in v1 review and from doing a bit of > git archeology I think it should be: > > c40a56a7818c ("x86/mm/init: Remove freed kernel image areas from alias mapping") > > because that thing added the clearing of the Present bit for the high > kernel image mapping of those areas. > > Right? Hmm, but that commit is in v4.19. Mike has added Cc: # 4.4+ Mike, why 4.4 and newer? Hmmm. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette