From: Tejun Heo <tj@kernel.org>
To: Yi Tao <escape@linux.alibaba.com>
Cc: gregkh@linuxfoundation.org, lizefan.x@bytedance.com,
hannes@cmpxchg.org, mcgrof@kernel.org, keescook@chromium.org,
yzaikin@google.com, linux-kernel@vger.kernel.org,
cgroups@vger.kernel.org, linux-fsdevel@vger.kernel.org,
shanpeic@linux.alibaba.com
Subject: Re: [RFC PATCH 0/2] support cgroup pool in v1
Date: Wed, 8 Sep 2021 06:35:11 -1000 [thread overview]
Message-ID: <YTjmP0EGEWGYhroM@slm.duckdns.org> (raw)
In-Reply-To: <cover.1631102579.git.escape@linux.alibaba.com>
Hello,
On Wed, Sep 08, 2021 at 08:15:11PM +0800, Yi Tao wrote:
> In order to solve this long-tail delay problem, we designed a cgroup
> pool. The cgroup pool will create a certain number of cgroups in advance.
> When a user creates a cgroup through the mkdir system call, a clean cgroup
> can be quickly obtained from the pool. Cgroup pool draws on the idea of
> cgroup rename. By creating pool and rename in advance, it reduces the
> critical area of cgroup creation, and uses a spinlock different from
> cgroup_mutex, which reduces scheduling overhead on the one hand, and eases
> competition with attaching processes on the other hand.
I'm not sure this is the right way to go about it. There are more
conventional ways to improve scalability - making locking more granular and
hunting down specific operations which take long time. I don't think cgroup
management operations need the level of scalability which requires front
caching.
Thanks.
--
tejun
next prev parent reply other threads:[~2021-09-08 16:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-08 12:15 [RFC PATCH 0/2] support cgroup pool in v1 Yi Tao
2021-09-08 12:15 ` [RFC PATCH 1/2] add pinned flags for kernfs node Yi Tao
2021-09-08 12:15 ` [RFC PATCH 2/2] support cgroup pool in v1 Yi Tao
2021-09-08 12:35 ` Greg KH
[not found] ` <084930d2-057a-04a7-76d1-b2a7bd37deb0@linux.alibaba.com>
2021-09-09 13:27 ` Greg KH
2021-09-10 2:20 ` taoyi.ty
2021-09-10 2:15 ` taoyi.ty
2021-09-10 6:01 ` Greg KH
2021-09-08 12:35 ` [RFC PATCH 1/2] add pinned flags for kernfs node Greg KH
2021-09-10 2:14 ` taoyi.ty
2021-09-10 6:00 ` Greg KH
2021-09-08 12:37 ` [RFC PATCH 0/2] support cgroup pool in v1 Greg KH
2021-09-10 2:11 ` taoyi.ty
2021-09-10 6:01 ` Greg KH
2021-09-10 16:49 ` Tejun Heo
2021-09-13 14:20 ` Christian Brauner
2021-09-13 16:24 ` Tejun Heo
2021-09-08 16:35 ` Tejun Heo [this message]
2021-09-10 2:12 ` taoyi.ty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTjmP0EGEWGYhroM@slm.duckdns.org \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=escape@linux.alibaba.com \
--cc=gregkh@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=mcgrof@kernel.org \
--cc=shanpeic@linux.alibaba.com \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).