From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0737C433EF for ; Fri, 10 Sep 2021 07:26:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C4089611BF for ; Fri, 10 Sep 2021 07:26:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231379AbhIJH1d (ORCPT ); Fri, 10 Sep 2021 03:27:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231290AbhIJH13 (ORCPT ); Fri, 10 Sep 2021 03:27:29 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 862FAC061574; Fri, 10 Sep 2021 00:26:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=087+0CiZqvP07DsW5DSevAPmxX0P+Bu6ZoYX2WEyOJQ=; b=Ik/NbsR162FqLJapnUR/sS8UKy nZsQzTiixipnJnpCTwF1/o3Py4Phj2l/15kz31oxyk0L5dXx6orfQv3hChQpUN5b8GDK3671W7vUO acBpWMQb6GNywBqMIpk84LeLKYiMYjr8Yt4QQ5iRQpktx6mFnEA5lzoOyUje88bqRP3wAZWFZSsxk tLxmEvjTbAFm3GEtoV6AT6euR3S6XjLvRYtcqvH3B2H8ig6IO5dmbxnpvnhei0pPVcekr5pQ14r5v y7Sx/MUn+A3UalVcwDOGV80URjJOxnRosjSO1YHOQB4Z9OJy1MK8JTqi6xEGHe6gs2gT/b45Wxi2E aCK0Wcmg==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mOatG-00AmTN-Ld; Fri, 10 Sep 2021 07:24:19 +0000 Date: Fri, 10 Sep 2021 08:24:02 +0100 From: Christoph Hellwig To: Linus Torvalds Cc: Christoph Hellwig , Andreas Gruenbacher , Alexander Viro , "Darrick J. Wong" , Jan Kara , Matthew Wilcox , cluster-devel , linux-fsdevel , Linux Kernel Mailing List , ocfs2-devel@oss.oracle.com Subject: Re: [PATCH v7 17/19] gup: Introduce FOLL_NOFAULT flag to disable page faults Message-ID: References: <20210827164926.1726765-1-agruenba@redhat.com> <20210827164926.1726765-18-agruenba@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Sep 09, 2021 at 10:17:14AM -0700, Linus Torvalds wrote: > So I think we should treat FOLL_FAST_ONLY as a special "internal to > gup.c" flag, and perhaps not really compare it to the new > FOLL_NOFAULT. > > In fact, maybe we could even just make FOLL_FAST_ONLY be the high bit, > and not expose it in and make it entirely private as a > name in gup.c. There are quite a few bits like that. I've been wanting to make them private for 5.16.