From: Matthew Wilcox <willy@infradead.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Rongwei Wang <rongwei.wang@linux.alibaba.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org,
viro@zeniv.linux.org.uk, song@kernel.org,
william.kucharski@oracle.com, hughd@google.com,
shy828301@gmail.com, linmiaohe@huawei.com, peterx@redhat.com
Subject: Re: [PATCH 0/3] mm, thp: introduce a new sysfs interface to facilitate file THP for .text
Date: Tue, 12 Oct 2021 02:50:39 +0100 [thread overview]
Message-ID: <YWTp7yjaN8W//Zrf@casper.infradead.org> (raw)
In-Reply-To: <YWPwjTEfeFFrJttQ@infradead.org>
On Mon, Oct 11, 2021 at 09:06:37AM +0100, Christoph Hellwig wrote:
> Can we please just get proper pagecache THP (through folios) merged
> instead of piling hacks over hacks here? The whole readonly THP already
> was more than painful enough due to all the hacks involved.
This was my initial reaction too.
But read the patches. They're nothing to do with the implementation of
THP / folios in the page cache. They're all to make sure that mappings
are PMD aligned.
I think there's a lot to criticise in the patches (eg, a system-wide
setting is probably a bad idea. and a lot of this stuff seems to
be fixing userspace bugs in the kernel). But let's criticise what's
actually in the patches, because these are problems that exist regardless
of RO_THP vs folios.
next prev parent reply other threads:[~2021-10-12 1:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-09 9:26 [PATCH 0/3] mm, thp: introduce a new sysfs interface to facilitate file THP for .text Rongwei Wang
2021-10-09 9:26 ` [PATCH 1/3] mm, thp: support binaries transparent use of file THP Rongwei Wang
2021-10-09 9:26 ` [PATCH 2/3] mm, thp: make mapping address of libraries THP align Rongwei Wang
2021-10-09 9:26 ` [PATCH 3/3] mm, thp: make mapping address of PIC binaries " Rongwei Wang
2021-10-11 8:06 ` [PATCH 0/3] mm, thp: introduce a new sysfs interface to facilitate file THP for .text Christoph Hellwig
2021-10-12 1:50 ` Matthew Wilcox [this message]
2021-10-12 7:04 ` Rongwei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWTp7yjaN8W//Zrf@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=hughd@google.com \
--cc=linmiaohe@huawei.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterx@redhat.com \
--cc=rongwei.wang@linux.alibaba.com \
--cc=shy828301@gmail.com \
--cc=song@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=william.kucharski@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).