From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2F7DC43219 for ; Fri, 12 Nov 2021 15:19:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 89C5B60F4F for ; Fri, 12 Nov 2021 15:19:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232887AbhKLPW3 (ORCPT ); Fri, 12 Nov 2021 10:22:29 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:42649 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232157AbhKLPW2 (ORCPT ); Fri, 12 Nov 2021 10:22:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636730376; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VFN3YfKrrN4rviirmH1lG0NY9uufAM6YHK0vPxccEaw=; b=IEmTYYOVu8mnNf8dncwvv63iPXnTzw+SDFVpHEr5SCq5O1ZxbPCmPqq7Wdw97KhFccVCcs PpvF0X6sLfvePo+htyPszZOVP9OPJFw+TC9+/jUt+DHqLVkcJdZ2V8c3AfrjHJX4R0Iaf/ vTUFGcudgKajU4OGV7+iJCc739D3CyQ= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-348-b4pib3pMOtC1ar_4gP5Vtg-1; Fri, 12 Nov 2021 10:19:35 -0500 X-MC-Unique: b4pib3pMOtC1ar_4gP5Vtg-1 Received: by mail-qv1-f70.google.com with SMTP id kj12-20020a056214528c00b003bde2e1df71so8611030qvb.18 for ; Fri, 12 Nov 2021 07:19:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=VFN3YfKrrN4rviirmH1lG0NY9uufAM6YHK0vPxccEaw=; b=CrA898Mga0PVhmSCgX1OMe77Yo5Sz1NQFMthWS+hvol6Od7BIC3gQRAwYtcaclan/e ZeaEx5QSY6C4IAsp6aBIuKQRpGnjftcGvOW3pH5lynMTQzqZ4G5N65W02H7PLHkp2WPe j4PjmYrb4y2D3RxNgpf3eopkMk47YFt2MJU+Sl9QWExtllkYkGx8ujgEcthfjvOpIeNf PQtqPDfrwBoK3SpqUNcTJTGVsy7gaB+vEU5Id2UJyo7Dsc7TOP1TpnGtMDcqFWWvlkdg jd7fXBRks827MzXJCIe+eBf8I8DJN1pPbRPFlR6ISrmYsoNCPpu7e3yLvKQvW3wR8G8h IBmg== X-Gm-Message-State: AOAM532KVU6rpN5Th9V8TrkUCTCJBMIsYXxcDl3kMCA+dn9Rd3NfOM41 YXTmNrKqlY+J7PFLYkxGk/omW4yZHGOwA7YfczW/RLVNx3OK1IBH0pyX2SMGV5fW0UzzlgdYDW1 JXEbjROhdhH54EhmVJCTUV5Sa X-Received: by 2002:a37:2f02:: with SMTP id v2mr13127487qkh.232.1636730375044; Fri, 12 Nov 2021 07:19:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJxk6sSDPzw7jrkKAxFn/K0PAx9HKUToVCIsJBG7fV34DkkAlHg0N9AMoil4JWoJAqjFdQQ15g== X-Received: by 2002:a37:2f02:: with SMTP id v2mr13127438qkh.232.1636730374828; Fri, 12 Nov 2021 07:19:34 -0800 (PST) Received: from localhost (pool-68-160-176-52.bstnma.fios.verizon.net. [68.160.176.52]) by smtp.gmail.com with ESMTPSA id az14sm2791255qkb.125.2021.11.12.07.19.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Nov 2021 07:19:34 -0800 (PST) Date: Fri, 12 Nov 2021 10:19:33 -0500 From: Mike Snitzer To: Chaitanya Kulkarni Cc: "linux-block@vger.kernel.org" , "linux-raid@vger.kernel.org" , "linux-nvme@lists.infradead.org" , "linux-scsi@vger.kernel.org" , "target-devel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-xfs@vger.kernel.org" , "dm-devel@redhat.com" , "axboe@kernel.dk" , "agk@redhat.com" , "song@kernel.org" , "djwong@kernel.org" , "kbusch@kernel.org" , "hch@lst.de" , "sagi@grimberg.me" , "jejb@linux.ibm.com" , "martin.petersen@oracle.com" , "viro@zeniv.linux.org.uk" , "javier@javigon.com" , "johannes.thumshirn@wdc.com" , "bvanassche@acm.org" , "dongli.zhang@oracle.com" , "ming.lei@redhat.com" , "osandov@fb.com" , "willy@infradead.org" , "jefflexu@linux.alibaba.com" , "josef@toxicpanda.com" , "clm@fb.com" , "dsterba@suse.com" , "jack@suse.com" , "tytso@mit.edu" , "adilger.kernel@dilger.ca" , "jlayton@kernel.org" , "idryomov@gmail.com" , "danil.kipnis@cloud.ionos.com" , "ebiggers@google.com" , "jinpu.wang@cloud.ionos.com" Subject: Re: [RFC PATCH 8/8] md: add support for REQ_OP_VERIFY Message-ID: References: <20211104064634.4481-1-chaitanyak@nvidia.com> <20211104064634.4481-9-chaitanyak@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Nov 11 2021 at 3:13P -0500, Chaitanya Kulkarni wrote: > On 11/3/2021 11:46 PM, Chaitanya Kulkarni wrote: > > From: Chaitanya Kulkarni > > > > Signed-off-by: Chaitanya Kulkarni > > I want to make sure the new REQ_OP_VERIFY is compatible with the > dm side as it is a generic interface. > > Any comments on the dm side ? It will help me to respin the series for > V1 of this proposal. I can review, but have you tested your XFS scrub usecase ontop of the various DM devices you modified? Also, you seem to have missed Keith's suggestion of using io_uring to expose this capability. If you happen to go that route: making sure DM has required io_uring capabilities would be needed (IIRC there were/are some lingering patches from Ming Lei to facilitate more efficient io_uring on DM.. I'll try to find, could be I'm wrong). Mike