From: "hch@infradead.org" <hch@infradead.org>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: "hch@infradead.org" <hch@infradead.org>,
Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
Linux FS Devel <linux-fsdevel@vger.kernel.org>,
"dm-devel@redhat.com" <dm-devel@redhat.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: Any bio_clone_slow() implementation which doesn't share bi_io_vec?
Date: Tue, 23 Nov 2021 23:02:52 -0800 [thread overview]
Message-ID: <YZ3jnFWk05058h/J@infradead.org> (raw)
In-Reply-To: <e3fce9af-429c-a1e3-3f0b-4d90fa061d94@gmx.com>
On Wed, Nov 24, 2021 at 02:18:00PM +0800, Qu Wenruo wrote:
> Just so simple? Then that's super awesome.
>
> But I'm a little concerned about the bio_add_hw_page() call in
> bio_add_zoned_append().
>
> It's not exactly the same as bio_add_page().
>
> Does it mean as long as our splitted bio doesn't exceed zone limit, we
> can do the convert without any further problem?
You need to look at the limits when splitting. I have modified
blk_bio_segment_split and exported it to deal with that. Let me split
those changes out cleanly and push out a branch.
next prev parent reply other threads:[~2021-11-24 7:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 6:44 Any bio_clone_slow() implementation which doesn't share bi_io_vec? Qu Wenruo
2021-11-23 7:43 ` Christoph Hellwig
2021-11-23 8:10 ` Qu Wenruo
2021-11-23 8:13 ` Christoph Hellwig
2021-11-23 11:09 ` Qu Wenruo
2021-11-23 11:39 ` Johannes Thumshirn
2021-11-23 14:28 ` hch
2021-11-23 23:07 ` Qu Wenruo
2021-11-24 6:09 ` hch
2021-11-24 6:18 ` Qu Wenruo
2021-11-24 7:02 ` hch [this message]
2021-11-24 7:22 ` hch
2021-11-24 7:25 ` Naohiro Aota
2021-11-24 7:39 ` Qu Wenruo
2021-11-26 12:33 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZ3jnFWk05058h/J@infradead.org \
--to=hch@infradead.org \
--cc=Johannes.Thumshirn@wdc.com \
--cc=dm-devel@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).