From: Matthew Wilcox <willy@infradead.org>
To: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs: Eliminate compilation warnings for misc
Date: Tue, 16 Nov 2021 17:19:11 +0000 [thread overview]
Message-ID: <YZPoD0SV8F/QfE1c@casper.infradead.org> (raw)
In-Reply-To: <20211116080611.31199-1-tianjia.zhang@linux.alibaba.com>
On Tue, Nov 16, 2021 at 04:06:11PM +0800, Tianjia Zhang wrote:
> Eliminate the following clang compilation warnings by adding or
> fixing function comment:
These warnings have nothing to do with clang. They're produced by
scripts/kernel-doc:
if (show_warnings($type, $declaration_name) && $param !~ /\./) {
print STDERR
"${file}:$.: warning: Function parameter or member '$param' not described in '$declaration_name'\n";
++$warnings;
}
They show up in any W=1 build (which tells you that people are not
checking their patches with W=1)
> +++ b/fs/file.c
> @@ -645,7 +645,7 @@ EXPORT_SYMBOL(close_fd); /* for ksys_close() */
>
> /**
> * last_fd - return last valid index into fd table
> - * @cur_fds: files struct
> + * @fdt: fdtable struct
I don't think the word 'struct' there really conveys any meaning.
next prev parent reply other threads:[~2021-11-16 17:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 8:06 [PATCH] fs: Eliminate compilation warnings for misc Tianjia Zhang
2021-11-16 17:19 ` Matthew Wilcox [this message]
2021-11-29 13:04 ` Tianjia Zhang
2021-11-16 23:00 ` Randy Dunlap
2021-11-29 13:06 ` Tianjia Zhang
2021-11-29 13:19 ` Matthew Wilcox
2021-12-01 9:51 ` Tianjia Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZPoD0SV8F/QfE1c@casper.infradead.org \
--to=willy@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=tianjia.zhang@linux.alibaba.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).