From: Christoph Hellwig <hch@infradead.org>
To: Muchun Song <songmuchun@bytedance.com>
Cc: akpm@linux-foundation.org, adobriyan@gmail.com,
gladkov.alexey@gmail.com, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2] fs: proc: store PDE()->data into inode->i_private
Date: Thu, 18 Nov 2021 23:23:39 -0800 [thread overview]
Message-ID: <YZdQ+0D7n5xCnw5A@infradead.org> (raw)
In-Reply-To: <20211119041104.27662-1-songmuchun@bytedance.com>
On Fri, Nov 19, 2021 at 12:11:04PM +0800, Muchun Song wrote:
> +
> +/*
> + * Obtain the private data passed by user through proc_create_data() or
> + * related.
> + */
> +static inline void *pde_data(const struct inode *inode)
> +{
> + return inode->i_private;
> +}
> +
> +#define PDE_DATA(i) pde_data(i)
What is the point of pde_data? If we really think changing to lower
case is worth it (I don't think so, using upper case for getting at
private data is a common idiom in file systems), we can just do that
scripted in one go.
next prev parent reply other threads:[~2021-11-19 7:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 4:11 [PATCH v2] fs: proc: store PDE()->data into inode->i_private Muchun Song
2021-11-19 7:23 ` Christoph Hellwig [this message]
2021-11-19 22:56 ` Andrew Morton
2021-11-22 4:13 ` Muchun Song
2021-11-24 3:10 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZdQ+0D7n5xCnw5A@infradead.org \
--to=hch@infradead.org \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=gladkov.alexey@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=songmuchun@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).