From: Matthew Wilcox <willy@infradead.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
Arnd Bergmann <arnd@arndb.de>, Peter Xu <peterx@redhat.com>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Yu Zhao <yuzhao@google.com>, Vlastimil Babka <vbabka@suse.cz>,
Colin Cross <ccross@google.com>,
Alistair Popple <apopple@nvidia.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Michal Hocko <mhocko@suse.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Hugh Dickins <hughd@google.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH] mm: split out anon_vma declarations to separate header
Date: Sat, 4 Dec 2021 23:53:26 +0000 [thread overview]
Message-ID: <Yav/dvIWxuZ59+d6@casper.infradead.org> (raw)
In-Reply-To: <20211204174417.1025328-1-arnd@kernel.org>
On Sat, Dec 04, 2021 at 06:42:17PM +0100, Arnd Bergmann wrote:
> This should not really be part of linux/mm_types.h in the first
> place, as that header is meant to only contain structure defintions
> and need a minimum set of indirect includes itself. While the
> header clearly includes more than it should at this point, let's
> not make it worse by including string.h as well, which would
> pull in the expensive (compile-speed wise) fortify-string logic.
>
> Move the new functions to a separate header that is only included
> where necessary to avoid bloating linux/mm_types.h further.
We already have an mm_inline.h. Why do we need a new header file?
next prev parent reply other threads:[~2021-12-04 23:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-04 17:42 [PATCH] mm: split out anon_vma declarations to separate header Arnd Bergmann
2021-12-04 23:53 ` Matthew Wilcox [this message]
2021-12-04 23:57 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yav/dvIWxuZ59+d6@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=ccross@google.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=peterx@redhat.com \
--cc=peterz@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=vbabka@suse.cz \
--cc=viro@zeniv.linux.org.uk \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).