From: Matthew Wilcox <willy@infradead.org>
To: David Howells <dhowells@redhat.com>
Cc: jlayton@kernel.org, ceph-devel@vger.kernel.org,
idryomov@gmail.com, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] ceph: Uninline the data on a file opened for writing
Date: Fri, 17 Dec 2021 16:20:00 +0000 [thread overview]
Message-ID: <Yby4sKDALDXHAbdT@casper.infradead.org> (raw)
In-Reply-To: <163975498535.2021751.13839139728966985077.stgit@warthog.procyon.org.uk>
On Fri, Dec 17, 2021 at 03:29:45PM +0000, David Howells wrote:
> If a ceph file is made up of inline data, uninline that in the ceph_open()
> rather than in ceph_page_mkwrite(), ceph_write_iter(), ceph_fallocate() or
> ceph_write_begin().
I don't think this is the right approach. Just opening a file with
O_RDWR shouldn't take it out of inline mode; an actual write (or fault)
should be required to uninline it.
> This makes it easier to convert to using the netfs library for VM write
> hooks.
I don't understand. You're talking about the fault path? Surely
the filesystem gets called with the vm_fault parameter only, then
calls into the netfs code, passing vmf and the operations struct?
And ceph could uninline there.
next prev parent reply other threads:[~2021-12-17 16:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 15:29 [PATCH v2 1/2] ceph: Uninline the data on a file opened for writing David Howells
2021-12-17 15:29 ` [PATCH v2 2/2] ceph: Remove some other inline-setting bits David Howells
2021-12-17 16:07 ` Jeff Layton
2021-12-17 16:05 ` [PATCH v2 1/2] ceph: Uninline the data on a file opened for writing Jeff Layton
2021-12-17 16:20 ` Matthew Wilcox [this message]
2021-12-17 17:18 ` Jeff Layton
2021-12-17 17:29 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yby4sKDALDXHAbdT@casper.infradead.org \
--to=willy@infradead.org \
--cc=ceph-devel@vger.kernel.org \
--cc=dhowells@redhat.com \
--cc=idryomov@gmail.com \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).