From: Luis Chamberlain <mcgrof@kernel.org>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Colin Ian King <colin.i.king@gmail.com>,
Kees Cook <keescook@chromium.org>,
Iurii Zaikin <yzaikin@google.com>,
Nathan Chancellor <nathan@kernel.org>,
Xiaoming Ni <nixiaoming@huawei.com>,
linux-fsdevel@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH][next] kernel/sysctl.c: remove unused variable ten_thousand
Date: Tue, 21 Dec 2021 14:48:42 -0800 [thread overview]
Message-ID: <YcJZyiUrlsPYExZ/@bombadil.infradead.org> (raw)
In-Reply-To: <CAKwvOdnK2Zc72tw6CdQkz=VxoRC0voWpda8Tgo38LaiRukDfKA@mail.gmail.com>
On Tue, Dec 21, 2021 at 02:17:41PM -0800, Nick Desaulniers wrote:
> On Tue, Dec 21, 2021 at 1:46 PM Luis Chamberlain <mcgrof@kernel.org> wrote:
> >
> > On Tue, Dec 21, 2021 at 06:45:01PM +0000, Colin Ian King wrote:
> > > The const variable ten_thousand is not used, it is redundant and can
> > > be removed.
> > >
> > > Cleans up clang warning:
> > > kernel/sysctl.c:99:18: warning: unused variable 'ten_thousand' [-Wunused-const-variable]
> > > static const int ten_thousand = 10000;
> > >
> > > Fixes: c26da54dc8ca ("printk: move printk sysctl to printk/sysctl.c")
> > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> >
> > Acked-by: Andrew Morton <akpm@linux-foundation.org>
>
> Just double checking; I don't think I've seen someone supply someone
> else's Acked by tag in a reply before. Was there some discussion off
> thread that I missed? If so, do you mind linking to it? Was this a
> typo, perhaps, and you meant to supply your own Acked by tag? Are
> "Luis Chamberlain" and "Andrew Morton" aliases? :^P
Haha sorry I copied and paste error.
Acked-by: Luis Chamberlain <mcgrof@kernel.org>
Luis
prev parent reply other threads:[~2021-12-21 22:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-21 18:45 [PATCH][next] kernel/sysctl.c: remove unused variable ten_thousand Colin Ian King
2021-12-21 21:45 ` Luis Chamberlain
2021-12-21 22:17 ` Nick Desaulniers
2021-12-21 22:48 ` Luis Chamberlain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcJZyiUrlsPYExZ/@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=colin.i.king@gmail.com \
--cc=keescook@chromium.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nixiaoming@huawei.com \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).