linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "hch@infradead.org" <hch@infradead.org>
To: Trond Myklebust <trondmy@hammerspace.com>
Cc: "dan.carpenter@oracle.com" <dan.carpenter@oracle.com>,
	"hch@infradead.org" <hch@infradead.org>,
	"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
	Lance Shelton <Lance.Shelton@hammerspace.com>,
	Richard Sharpe <Richard.Sharpe@hammerspace.com>,
	"Anna.Schumaker@netapp.com" <Anna.Schumaker@netapp.com>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [bug report] NFS: Support statx_get and statx_set ioctls
Date: Wed, 12 Jan 2022 00:06:38 -0800	[thread overview]
Message-ID: <Yd6MDkMJaU0ACMEH@infradead.org> (raw)
In-Reply-To: <56202063c1eba6020b356a393178b9626652198e.camel@hammerspace.com>

On Tue, Jan 11, 2022 at 06:08:27PM +0000, Trond Myklebust wrote:
> So firstly, there already has been a discussion of this on linux-
> fsdevel (and linux-kernel):
> https://lore.kernel.org/lkml/20160429125813.23636.49830.stgit@warthog.procyon.org.uk/
> and the consensus at the time was that these attributes were not needed
> in statx.

And apparently someone now has a different opinion, so we should restart
it.

> 
> The other issue is that this is not a duplicate of stat. It's adding
> support for both _setting_ and reading back these attributes. The
> ability to supporting reading the archive bit / backup time, for
> example, is completely useless unless you can also set those values
> after backing up the file. Right now, there is no support in the VFS
> for setting any attributes that are not part of the standard POSIX set.

Either way this has no business being private in NFS.  We need to
come to an agreement to have a proper interface for CIFS, fat, exfat
and the 2 ntfs drivers as welŀ.  With the first three being the most
important ones.

So big fat nack for stashing something like this into nfs without proper
review and coordination.

  reply	other threads:[~2022-01-12  8:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220111074309.GA12918@kili>
2022-01-11  8:48 ` [bug report] NFS: Support statx_get and statx_set ioctls Christoph Hellwig
2022-01-11 10:48   ` Christian Brauner
2022-01-11 18:08   ` Trond Myklebust
2022-01-12  8:06     ` hch [this message]
2022-01-12  7:57   ` Amir Goldstein
2022-01-12 17:43     ` Darrick J. Wong
2022-01-13  3:52       ` Amir Goldstein
2022-01-13  6:30         ` Jeremy Allison
2022-01-13 14:58           ` Trond Myklebust
2022-01-13 17:50             ` Jeremy Allison
2022-01-13 15:01     ` Trond Myklebust

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yd6MDkMJaU0ACMEH@infradead.org \
    --to=hch@infradead.org \
    --cc=Anna.Schumaker@netapp.com \
    --cc=Lance.Shelton@hammerspace.com \
    --cc=Richard.Sharpe@hammerspace.com \
    --cc=dan.carpenter@oracle.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trondmy@hammerspace.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).