From: Christoph Hellwig <hch@infradead.org>
To: Hugh Dickins <hughd@google.com>
Cc: Matthew Wilcox <willy@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Hellwig <hch@infradead.org>, Jan Kara <jack@suse.cz>,
William Kucharski <william.kucharski@oracle.com>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH next 1/3] truncate,shmem: Fix data loss when hole punched in folio
Date: Sun, 2 Jan 2022 23:51:17 -0800 [thread overview]
Message-ID: <YdKq9bOcZ0M30LZ8@infradead.org> (raw)
In-Reply-To: <43bf0e3-6ad8-9f67-7296-786c7b3b852f@google.com>
On Sun, Jan 02, 2022 at 05:32:28PM -0800, Hugh Dickins wrote:
>
> + same_folio = (lstart >> PAGE_SHIFT) == (lend >> PAGE_SHIFT);
Should this move to the else branch?
Same for the other copy of this code. Otherwise this looks sane.
next prev parent reply other threads:[~2022-01-03 7:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-03 1:32 [PATCH next 1/3] truncate,shmem: Fix data loss when hole punched in folio Hugh Dickins
2022-01-03 7:51 ` Christoph Hellwig [this message]
2022-01-03 20:17 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdKq9bOcZ0M30LZ8@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=william.kucharski@oracle.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).