From: Matthew Wilcox <willy@infradead.org>
To: Muchun Song <songmuchun@bytedance.com>
Cc: dan.j.williams@intel.com, jack@suse.cz, viro@zeniv.linux.org.uk,
akpm@linux-foundation.org, apopple@nvidia.com,
shy828301@gmail.com, rcampbell@nvidia.com, hughd@google.com,
xiyuyang19@fudan.edu.cn, kirill.shutemov@linux.intel.com,
zwisler@kernel.org, hch@infradead.org,
linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
duanxiongchun@bytedance.com
Subject: Re: [PATCH v2 3/6] mm: page_vma_mapped: support checking if a pfn is mapped into a vma
Date: Wed, 2 Feb 2022 18:28:26 +0000 [thread overview]
Message-ID: <YfrNSvttbQgLKKwj@casper.infradead.org> (raw)
In-Reply-To: <20220202143307.96282-4-songmuchun@bytedance.com>
On Wed, Feb 02, 2022 at 10:33:04PM +0800, Muchun Song wrote:
> page_vma_mapped_walk() is supposed to check if a page is mapped into a vma.
> However, not all page frames (e.g. PFN_DEV) have a associated struct page
> with it. There is going to be some duplicate codes similar with this function
> if someone want to check if a pfn (without a struct page) is mapped into a
> vma. So add support for checking if a pfn is mapped into a vma. In the next
> patch, the dax will use this new feature.
I'm coming to more or less the same solution for fixing the bug in
page_mapped_in_vma(). If you call it with a head page, it will look
for any page in the THP instead of the precise page. I think we can do
a fairly significant simplification though, so I'm going to go off
and work on that next ...
next prev parent reply other threads:[~2022-02-02 18:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-02 14:33 [PATCH v2 0/6] Fix some bugs related to ramp and dax Muchun Song
2022-02-02 14:33 ` [PATCH v2 1/6] mm: rmap: fix cache flush on THP pages Muchun Song
2022-02-03 10:16 ` Jan Kara
2022-02-02 14:33 ` [PATCH v2 2/6] dax: fix cache flush on PMD-mapped pages Muchun Song
2022-02-03 10:17 ` Jan Kara
2022-02-02 14:33 ` [PATCH v2 3/6] mm: page_vma_mapped: support checking if a pfn is mapped into a vma Muchun Song
2022-02-02 18:28 ` Matthew Wilcox [this message]
2022-02-02 14:33 ` [PATCH v2 4/6] mm: rmap: introduce pfn_mkclean_range() to cleans PTEs Muchun Song
2022-02-02 14:33 ` [PATCH v2 5/6] dax: fix missing writeprotect the pte entry Muchun Song
2022-02-02 14:33 ` [PATCH v2 6/6] mm: remove range parameter from follow_invalidate_pte() Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfrNSvttbQgLKKwj@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=dan.j.williams@intel.com \
--cc=duanxiongchun@bytedance.com \
--cc=hch@infradead.org \
--cc=hughd@google.com \
--cc=jack@suse.cz \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nvdimm@lists.linux.dev \
--cc=rcampbell@nvidia.com \
--cc=shy828301@gmail.com \
--cc=songmuchun@bytedance.com \
--cc=viro@zeniv.linux.org.uk \
--cc=xiyuyang19@fudan.edu.cn \
--cc=zwisler@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).