From: Luis Chamberlain <mcgrof@kernel.org>
To: Meng Tang <tangmeng@uniontech.com>
Cc: keescook@chromium.org, yzaikin@google.com, ebiederm@xmission.com,
willy@infradead.org, nixiaoming@huawei.com, nizhen@uniontech.com,
zhanglianjie@uniontech.com, sujiaxun@uniontech.com,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] fs/proc: optimize exactly register one ctl_table
Date: Tue, 1 Mar 2022 09:44:33 -0800 [thread overview]
Message-ID: <Yh5bgYQM9a0ox95a@bombadil.infradead.org> (raw)
In-Reply-To: <20220301115341.30101-1-tangmeng@uniontech.com>
On Tue, Mar 01, 2022 at 07:53:40PM +0800, Meng Tang wrote:
> Sysctls are being moved out of kernel/sysctl.c and out to
> their own respective subsystems / users to help with easier
> maintance and avoid merge conflicts. But when we move just
> one entry and to its own new file the last entry for this
> new file must be empty, so we are essentialy bloating the
> kernel one extra empty entry per each newly moved sysctl.
>
> To help with this, this adds support for registering just
> one ctl_table, therefore not bloating the kernel when we
> move a single ctl_table to its own file.
>
> Suggested-by: Matthew Wilcox <willy@infradead.org>
> Signed-off-by: Meng Tang <tangmeng@uniontech.com>
Please extend the commit log to justify why we have to add
so much code, you mentioned it to me before, now just please
write that in the commit log.
Can you really not add helpers first so that these helpers
are used by both paths?
Luis
prev parent reply other threads:[~2022-03-01 17:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 11:53 [PATCH v2 1/2] fs/proc: optimize exactly register one ctl_table Meng Tang
2022-03-01 11:53 ` [PATCH v2 2/2] fs/proc: sysctl: optimize register single " Meng Tang
2022-03-01 16:06 ` [PATCH v2 1/2] fs/proc: optimize exactly register " kernel test robot
2022-03-01 16:06 ` kernel test robot
2022-03-01 16:06 ` kernel test robot
2022-03-01 17:44 ` Luis Chamberlain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yh5bgYQM9a0ox95a@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=ebiederm@xmission.com \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nixiaoming@huawei.com \
--cc=nizhen@uniontech.com \
--cc=sujiaxun@uniontech.com \
--cc=tangmeng@uniontech.com \
--cc=willy@infradead.org \
--cc=yzaikin@google.com \
--cc=zhanglianjie@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).