From: Luis Chamberlain <mcgrof@kernel.org>
To: Baoquan He <bhe@redhat.com>
Cc: yingelin <yingelin@huawei.com>,
ebiederm@xmission.com, keescook@chromium.org, yzaikin@google.com,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, zengweilin@huawei.com,
chenjianguo3@huawei.com, nixiaoming@huawei.com,
qiuguorui1@huawei.com, young.liuyang@huawei.com
Subject: Re: [PATCH sysctl-next] kernel/kexec_core: move kexec_core sysctls into its own file
Date: Sat, 26 Feb 2022 12:20:44 -0800 [thread overview]
Message-ID: <YhqLnIjopfoBEBcV@bombadil.infradead.org> (raw)
In-Reply-To: <Yhbu6UxoYXFtDyFk@fedora>
On Thu, Feb 24, 2022 at 10:35:21AM +0800, Baoquan He wrote:
> That seems to be an issue everything related to sysctl are all added to
> kernel/sysctl.c. Do you have a pointer that someone complained about it
> and people agree to scatter them into their own component code?
https://lkml.kernel.org/r/20220226031054.47DF8C340E7@smtp.kernel.org
> I understand your concern now, I am personally not confused by that
> maybe because I haven't got stuff adding or changing into sysctls. My
> concern is if we only care and move kexec knob, or we have plan to try
> to move all of them. If there's some background information or
> discussion with a link, that would be helpful.
We're moving them all out. Sorry, yingelin's commit log message sucks
and it needs to be fixed to account for the justification. All the
filesystem sysctls are already moved out. Slowly we are moving the other
ones out and also doing minor optimizations along the way.
Luis
next prev parent reply other threads:[~2022-02-26 20:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 3:03 [PATCH sysctl-next] kernel/kexec_core: move kexec_core sysctls into its own file yingelin
2022-02-23 8:30 ` Baoquan He
2022-02-24 1:04 ` yingelin
2022-02-24 2:35 ` Baoquan He
2022-02-26 20:20 ` Luis Chamberlain [this message]
2022-02-28 1:43 ` yingelin
2022-02-28 3:18 ` Baoquan He
2022-04-15 22:59 ` Luis Chamberlain
2022-02-28 1:41 ` yingelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhqLnIjopfoBEBcV@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=bhe@redhat.com \
--cc=chenjianguo3@huawei.com \
--cc=ebiederm@xmission.com \
--cc=keescook@chromium.org \
--cc=kexec@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nixiaoming@huawei.com \
--cc=qiuguorui1@huawei.com \
--cc=yingelin@huawei.com \
--cc=young.liuyang@huawei.com \
--cc=yzaikin@google.com \
--cc=zengweilin@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).