From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89F36C433EF for ; Sat, 26 Feb 2022 21:02:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229714AbiBZVDD (ORCPT ); Sat, 26 Feb 2022 16:03:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229710AbiBZVDD (ORCPT ); Sat, 26 Feb 2022 16:03:03 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C813DFC7; Sat, 26 Feb 2022 13:02:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=t5PvKUiCfOMquPumfQ4cEUgcoR3Wsv7oMQVd0HhO0Zo=; b=gtNP4G6fJqE4QOtsMvUMIVFpQ4 usPnT7I8lr5qMEgoySSAWt79IYauedv87xchUhNtpl7pnUuuRmvckbPV6Jrh5QQRePDS6sPnrEQDd mLQ0Ey83QSIJDK7LZAYz8RaD9Ty3Uk4YPD8g08lRJITopv9NFbKS0T6ivFF2JXpzjxWqLKHWfLMs7 /1pUHclLHba1zIqBZlA3gQ5Fdj504mt++KNl0uh9fqrQ9NvJbk0RXdsU+cxFtTCjnPBSHCngUnrxJ dos+hBJALOqBjdOz1d/nnI/Uul/HHo8YsphtGDRkybBB1eyTqR3HR5r/4/hbB0g5TVXmt2v3P+8gM 8tVWXt+A==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nO4Cp-008XqG-Id; Sat, 26 Feb 2022 21:02:19 +0000 Date: Sat, 26 Feb 2022 13:02:19 -0800 From: Luis Chamberlain To: tangmeng Cc: viro@zeniv.linux.org.uk, akpm@linux-foundation.org, keescook@chromium.org, yzaikin@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, nizhen@uniontech.com, zhanglianjie@uniontech.com, nixiaoming@huawei.com Subject: Re: [PATCH v2 10/11] fs/drop_caches: move drop_caches sysctls to its own file Message-ID: References: <20220221061018.10472-1-tangmeng@uniontech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220221061018.10472-1-tangmeng@uniontech.com> Sender: Luis Chamberlain Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, Feb 21, 2022 at 02:10:18PM +0800, tangmeng wrote: > kernel/sysctl.c is a kitchen sink where everyone leaves their dirty > dishes, this makes it very difficult to maintain. > > To help with this maintenance let's start by moving sysctls to places > where they actually belong. The proc sysctl maintainers do not want to > know what sysctl knobs you wish to add for your own piece of code, we > just care about the core logic. > > All filesystem syctls now get reviewed by fs folks. This commit > follows the commit of fs, move the drop_caches sysctls to its own file, > fs/drop_caches.c. > > Signed-off-by: tangmeng Thanks but please send a v3 including all the other patches as well and collecting the Reviewed/Acked-bys, etc. This can be sent *after* your v3 of the optimization work. Luis