From: Max Kellermann <max@blarg.de>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] include/pipe_fs_i.h: add missing #includes
Date: Sun, 13 Mar 2022 07:45:14 +0100 [thread overview]
Message-ID: <Yi2S+n+0lnuua4eC@swift.blarg.de> (raw)
In-Reply-To: <Yi1NkNkL5N1m4yU5@zeniv-ca.linux.org.uk>
On 2022/03/13 02:49, Al Viro <viro@zeniv.linux.org.uk> wrote:
> TBH, I'd rather avoid breeding chain includes; sure, mutex.h and wait.h
> are extremely common anyway. Oh, well....
In my usual coding style, I expect I can include any header and it
will bring its whole dependency chain (which should be as small as
possible, but not smaller). This seems cleaner to me, because .c
files need to have no insight what a .h file needs (even if the
dependencies are "extremely common").
If the kernel coding style does not consider this useful, we can of
course easily drop that patch.
prev parent reply other threads:[~2022-03-13 6:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 18:54 [PATCH 1/4] include/pipe_fs_i.h: add missing #includes Max Kellermann
2022-02-25 18:54 ` [PATCH 2/4] fs/pipe: remove duplicate "offset" initializer Max Kellermann
2022-02-25 18:54 ` [PATCH 3/4] fs/pipe: remove unnecessary "buf" initializer Max Kellermann
2022-02-25 18:54 ` [PATCH 4/4] pipe_fs_i.h: add pipe_buf_init() Max Kellermann
2022-03-13 2:37 ` Al Viro
2022-03-13 2:48 ` Matthew Wilcox
2022-03-13 4:34 ` Al Viro
2022-03-13 6:47 ` Max Kellermann
2022-03-13 1:49 ` [PATCH 1/4] include/pipe_fs_i.h: add missing #includes Al Viro
2022-03-13 6:45 ` Max Kellermann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yi2S+n+0lnuua4eC@swift.blarg.de \
--to=max@blarg.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).