From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70D90C433F5 for ; Tue, 22 Mar 2022 08:37:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231359AbiCVIjP (ORCPT ); Tue, 22 Mar 2022 04:39:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231297AbiCVIjO (ORCPT ); Tue, 22 Mar 2022 04:39:14 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD37F6AA4D; Tue, 22 Mar 2022 01:37:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=dM4Devf9AxYRsJbry+GdljYWNC1RVwNRs/wmrQdV5X0=; b=F7D+qgEn0hYzxLExaBQdxlCTo7 +Nzq36CHgpBmxsqxnHpmCLkzUrhOvePCCPAWtfbSGjKobx5cSHnL74IWm0cFRv8z+kJaFY0fDCbPD XmS2uP+/64IE9eeKEUHpwXN3RTN0Epc9SfCmR81EfmjgDaG6RdRPh4zbxoC4/kuEv/C+wS0KpGpof PllcHUQ46QDdKv/LYXQggc87GTszPdWrb5EEkEcVllPvuBFDNbdQzl7SzFECUcQ+XfE4qpFlCBV7X WFSz3lzoTDVpRPg+1VXBTlioMvfgERhyIoFAmmDcPo4TyCPy9aeGsKAZ06Kv2hUubDr5goafl6Lq8 jPxEabuQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWa1J-00ARWh-66; Tue, 22 Mar 2022 08:37:37 +0000 Date: Tue, 22 Mar 2022 01:37:37 -0700 From: Christoph Hellwig To: Muchun Song Cc: dan.j.williams@intel.com, willy@infradead.org, jack@suse.cz, viro@zeniv.linux.org.uk, akpm@linux-foundation.org, apopple@nvidia.com, shy828301@gmail.com, rcampbell@nvidia.com, hughd@google.com, xiyuyang19@fudan.edu.cn, kirill.shutemov@linux.intel.com, zwisler@kernel.org, hch@infradead.org, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, duanxiongchun@bytedance.com, smuchun@gmail.com Subject: Re: [PATCH v5 5/6] dax: fix missing writeprotect the pte entry Message-ID: References: <20220318074529.5261-1-songmuchun@bytedance.com> <20220318074529.5261-6-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220318074529.5261-6-songmuchun@bytedance.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org > +static void dax_entry_mkclean(struct address_space *mapping, unsigned long pfn, > + unsigned long npfn, pgoff_t start) > { > struct vm_area_struct *vma; > + pgoff_t end = start + npfn - 1; > > i_mmap_lock_read(mapping); > + vma_interval_tree_foreach(vma, &mapping->i_mmap, start, end) { > + pfn_mkclean_range(pfn, npfn, start, vma); > cond_resched(); > } > i_mmap_unlock_read(mapping); Is there any point in even keeping this helper vs just open coding it in the only caller below? Otherwise looks good: Reviewed-by: Christoph Hellwig