From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73D4DC433FE for ; Wed, 30 Mar 2022 14:53:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238798AbiC3Ozj (ORCPT ); Wed, 30 Mar 2022 10:55:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347705AbiC3Ozb (ORCPT ); Wed, 30 Mar 2022 10:55:31 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A363F674EB for ; Wed, 30 Mar 2022 07:53:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=yzu252QPBiI376hjwGJQTIrM0etmUmbtIsQJ6LliUu8=; b=ZI2lxAgXOwQhzSUVgCPP1c/UBX lbm9EH7WJNKgC88NESa2w9foNWrfEqdmL42AKP3S9TAGDBz+x9/Akkt32fGxHpsTNPtoFFM/vqMoU co+KLp62u0drZbDlJG5Z7C0tVAF3JPIpll+3Su+Rd6n5oneeTg4DP7jMEBXBpz6FVbMNekhB5mfyT Tu/BE+rDGsng+OMIPjytgw0IUMnndYkl5QVJyPdk7luBiPjnsPTwMMbQPdtSDhufyMpZnEMWnMCwg vuKN9cre/xftgp3/YdQgzz+b2GlpplzTEUc0BrlgY73KUF3t4ecYwdMG11XJH40vyqIYzM0ZsbXVm yYNzmUyQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZZhH-00GK9l-9K; Wed, 30 Mar 2022 14:53:19 +0000 Date: Wed, 30 Mar 2022 07:53:19 -0700 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 09/12] f2fs: Correct f2fs_dirty_data_folio() conversion Message-ID: References: <20220330144930.315951-1-willy@infradead.org> <20220330144930.315951-10-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220330144930.315951-10-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Mar 30, 2022 at 03:49:27PM +0100, Matthew Wilcox (Oracle) wrote: > I got the return value wrong. Very little checks the return value > from set_page_dirty(), so nobody noticed during testing. Looks good, Reviewed-by: Christoph Hellwig