From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1BCDC4332F for ; Wed, 30 Mar 2022 14:52:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344752AbiC3OyT (ORCPT ); Wed, 30 Mar 2022 10:54:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55454 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347878AbiC3OxL (ORCPT ); Wed, 30 Mar 2022 10:53:11 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4CC44926A for ; Wed, 30 Mar 2022 07:51:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=pUF2K7pAIIMFFXlBDPAhTM/LC99BSpeM4v+oDEUb7Ho=; b=Vh7Ae4g0umgmrn/cwBamht5TnP vSnVd8QLu+FRPbb5U8gXnCzjtOJOJVUzrLxTt2nPxcsYPHrRaQDCpl3UJsXWCmZScA5xxQIr4Xuam ELjViT06mynX0YjVXJm1UV0L8J0Blp936WFRT6Q/eTUw8X86G99vl2iwLxPYzidlWn/E0xK9u3Xdj 0khHMcF6feyEq+XUzV68cxwoyJ210rxvaFX+ag7xA7rK2AdCoZFv6MKdyM3CN9m9McwjnPQWLbJ7J S+ptwBrSl0T7Un5RA5tSvnEJFtZIk/EWBEe/EipRDVDWjSIxQGdes8iTu65UBUFnPU0Ixr20y1yeD Dt70Rduw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZZfR-00GJ3H-CT; Wed, 30 Mar 2022 14:51:25 +0000 Date: Wed, 30 Mar 2022 07:51:25 -0700 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 02/12] fs: Remove ->readpages address space operation Message-ID: References: <20220330144930.315951-1-willy@infradead.org> <20220330144930.315951-3-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220330144930.315951-3-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Mar 30, 2022 at 03:49:20PM +0100, Matthew Wilcox (Oracle) wrote: > All filesystems have now been converted to use ->readahead, so > remove the ->readpages operation and fix all the comments that > used to refer to it. Looks good: Reviewed-by: Christoph Hellwig