From: Michal Hocko <mhocko@suse.com>
To: Kent Overstreet <kent.overstreet@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org, roman.gushchin@linux.dev,
hannes@cmpxchg.org
Subject: Re: [PATCH 3/4] mm: Centralize & improve oom reporting in show_mem.c
Date: Wed, 20 Apr 2022 08:58:36 +0200 [thread overview]
Message-ID: <Yl+vHJ3lSLn5ZkWN@dhcp22.suse.cz> (raw)
In-Reply-To: <20220419203202.2670193-4-kent.overstreet@gmail.com>
On Tue 19-04-22 16:32:01, Kent Overstreet wrote:
> This patch:
> - Moves lib/show_mem.c to mm/show_mem.c
Sure, why not. Should be a separate patch.
> - Changes show_mem() to always report on slab usage
> - Instead of reporting on all slabs, we only report on top 10 slabs,
> and in sorted order
> - Also reports on shrinkers, with the new shrinkers_to_text().
Why do we need/want this? It would be also great to provide an example
of why the new output is better (in which cases) than the existing one.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2022-04-20 6:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-19 20:31 [PATCH 0/4] Printbufs & shrinker OOM reporting Kent Overstreet
2022-04-19 20:31 ` [PATCH 1/4] lib/printbuf: New data structure for heap-allocated strings Kent Overstreet
2022-04-19 21:11 ` Matthew Wilcox
2022-04-20 0:12 ` Kent Overstreet
2022-04-20 5:02 ` Christoph Hellwig
2022-04-20 5:18 ` Kent Overstreet
2022-04-19 20:32 ` [PATCH 2/4] mm: Add a .to_text() method for shrinkers Kent Overstreet
2022-04-19 20:32 ` [PATCH 3/4] mm: Centralize & improve oom reporting in show_mem.c Kent Overstreet
2022-04-20 6:58 ` Michal Hocko [this message]
2022-04-20 16:58 ` Kent Overstreet
2022-04-21 9:18 ` Michal Hocko
2022-04-21 18:42 ` Kent Overstreet
2022-04-22 8:03 ` Michal Hocko
2022-04-22 8:30 ` Kent Overstreet
2022-04-22 9:27 ` Michal Hocko
2022-04-22 9:44 ` Kent Overstreet
2022-04-22 10:51 ` Michal Hocko
2022-04-22 10:58 ` Kent Overstreet
2022-04-19 20:32 ` [PATCH 4/4] bcachefs: shrinker.to_text() methods Kent Overstreet
-- strict thread matches above, loose matches on Subject: below --
2022-04-21 23:48 [PATCH 0/4] Printbufs & shrinker OOM reporting Kent Overstreet
2022-04-21 23:48 ` [PATCH 3/4] mm: Centralize & improve oom reporting in show_mem.c Kent Overstreet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yl+vHJ3lSLn5ZkWN@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=hannes@cmpxchg.org \
--cc=kent.overstreet@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=roman.gushchin@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).