From: Christoph Hellwig <hch@infradead.org>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: Douglas Gilbert <dgilbert@interlog.com>,
linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-modules@vger.kernel.org,
Chaitanya Kulkarni <kch@nvidia.com>,
Bart Van Assche <bvanassche@acm.org>,
Lucas De Marchi <lucas.demarchi@intel.com>,
Pankaj Malhotra <pankaj1.m@samsung.com>,
Vincent Fu <vincent.fu@samsung.com>
Subject: Re: scsi_debug in fstests and blktests (Was: Re: Fwd: [bug report][bisected] modprob -r scsi-debug take more than 3mins during blktests srp/ tests)
Date: Thu, 21 Apr 2022 22:56:57 -0700 [thread overview]
Message-ID: <YmJDqceT1AiePyxj@infradead.org> (raw)
In-Reply-To: <YmGaGoz2+Kdqu05l@bombadil.infradead.org>
On Thu, Apr 21, 2022 at 10:53:30AM -0700, Luis Chamberlain wrote:
> Moving this discussion to the lists as we need to really think
> about how testing on fstests and blktests uses scsi_debug for
> a high confidence in baseline without false positives on failures
> due to the inability to the remove scsi_debug module.
>
> This should also apply to other test debug modules like null_blk,
> nvme target loop drivers, etc, it's all the same long term. But yeah
> scsi surely make this... painful today. In any case hopefully folks
> with other test debug drivesr are running tests to ensure you can
> always rmmod these modules regardless of what is happening.
Maybe fix blktests to not rely on module removal I have such a hard
time actually using blktests because it is suck a f^^Y% broken piece
of crap that assumes everything is modular. Stop making that whole
assumption and work fine with built-in driver as a first step. Then
start worrying about module removal.
next prev parent reply other threads:[~2022-04-22 5:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAHj4cs9OTm9sb_5fmzgz+W9OSLeVPKix3Yri856kqQVccwd_Mw@mail.gmail.com>
[not found] ` <fba69540-b623-9602-a0e2-00de3348dbd6@interlog.com>
[not found] ` <YlW7gY8nr9LnBEF+@bombadil.infradead.org>
[not found] ` <00ebace8-b513-53c0-f13b-d3320757695d@interlog.com>
2022-04-21 17:53 ` scsi_debug in fstests and blktests (Was: Re: Fwd: [bug report][bisected] modprob -r scsi-debug take more than 3mins during blktests srp/ tests) Luis Chamberlain
2022-04-22 5:56 ` Christoph Hellwig [this message]
2022-04-22 12:34 ` Theodore Ts'o
2022-04-22 15:08 ` Luis Chamberlain
2022-04-22 15:19 ` Christoph Hellwig
2022-04-22 15:06 ` Luis Chamberlain
2022-04-23 16:50 ` Christoph Hellwig
2022-04-26 6:27 ` Chaitanya Kulkarni
2022-04-25 19:22 ` Douglas Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmJDqceT1AiePyxj@infradead.org \
--to=hch@infradead.org \
--cc=bvanassche@acm.org \
--cc=dgilbert@interlog.com \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=mcgrof@kernel.org \
--cc=pankaj1.m@samsung.com \
--cc=vincent.fu@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).