From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5409BC4332F for ; Wed, 4 May 2022 21:12:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378518AbiEDVQO (ORCPT ); Wed, 4 May 2022 17:16:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238438AbiEDVQM (ORCPT ); Wed, 4 May 2022 17:16:12 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2BA5F4A92C; Wed, 4 May 2022 14:12:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=yqErQjmS+bnUS13HloDHpaivj9GT+Qdx14G8nSP6Cog=; b=qd8R7nTQdEKUrp5XQwz8zr0tax LPOrH0DhAKEN9lLc/py2/4c+i94bgjTT8Z40U95XqlVChQAHQ9BBmkBrXX+nIUy9NHDlkPINMdAqN zq8vsIDGMxMCUOWxdegzbmmIZ26ZPJ6R/iVLKsB/jQ0aDic8qdT+14tNt32smVnbFdiqDxwB2zADN 3mDOsk0AK4hyt4InvnhTeLItp3d/5nVvbcqNWdKfnSAoyfivSjocwCtsu8M79pIOoW/5oCB5gsnle JBCLIoK7rdonK5qoHipzIwFHMv9DC5MJ84zgFNw9Mda0x1SdGcydIzf37GfjwHGKjKUlNvRDlSUE2 CYabBD0A==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmMIQ-00CkOY-PP; Wed, 04 May 2022 21:12:30 +0000 Date: Wed, 4 May 2022 14:12:30 -0700 From: Luis Chamberlain To: Daniel Latypov , Shuah Khan Cc: David Gow , Lucas De Marchi , Aaron Tomlin , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, Brendan Higgins , Andy Shevchenko , Jonathan Corbet , Andrew Morton , Kees Cook , Greg KH , "Guilherme G . Piccoli" , Sebastian Reichel , John Ogness , Joe Fradley , kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Jani Nikula Subject: Re: [PATCH v2] kunit: Taint kernel if any tests run Message-ID: References: <20220429043913.626647-1-davidgow@google.com> <20220430030019.803481-1-davidgow@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Luis Chamberlain Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, May 04, 2022 at 02:19:59PM -0500, Daniel Latypov wrote: > On Wed, May 4, 2022 at 1:46 PM Luis Chamberlain wrote: > > OK so, we can just skip tainting considerations for selftests which > > don't use modules for now. There may be selftests which do wonky > > things in userspace but indeed I agree the userspace taint would > > be better for those but I don't think it may be worth bother > > worrying about those at this point in time. > > > > But my point in that sharing a taint between kunit / selftests modules > > does make sense and is easily possible. The unfortunate aspect is just > > Yes, I 100% agree that we should share a taint for kernelspace testing > from both kunit/kselftest. > Someone running the system won't care what framework was used. OK do you mind doing the nasty work of manually adding the new MODULE_TAINT() to the selftests as part of your effort? *Alternatively*, if we *moved* all sefltests modules to a new lib/debug/selftests/ directory or something like that then t would seem modpost *could* add the taint flag automagically for us without having to edit or require it on new drivers. We have similar type of taint for staging, see add_staging_flag(). I would *highly* prefer this approach, event though it is more work, because I think this is a step we should take anyway. However, I just checked modules on lib/ and well, some of them are already in their own directory, like lib/math/test_div64.c. So not sure, maybe just move a few modules which are just in lib/*.c for now and then just sprinkle the MODULE_TAINT() to the others? > > that selftests don't have a centralized runner, because I can just > > run tools/testing/selftests/sysctl/sysctl.sh for example and that's it. > > So I think we have no other option but to just add the module info > > manually for selftests at this time. > > Somewhat tangential: there's a number of other test modules that > aren't explicitly part of kselftest. Oh interesting, like which one? > Long-term, I think most of them should be converted to kselftest or > kunit as appropriate, so they'll get taken care of eventually. Makes sense. Luis