From: Christoph Hellwig <hch@infradead.org>
To: Vasily Averin <vvs@openvz.org>
Cc: Jan Kara <jack@suse.cz>, Alexander Viro <viro@zeniv.linux.org.uk>,
kernel@openvz.org, linux-kernel@vger.kernel.org,
Amir Goldstein <amir73il@gmail.com>,
Matthew Bobrowski <repnop@google.com>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] sparse: use force attribute for fmode_t casts
Date: Mon, 16 May 2022 23:38:59 -0700 [thread overview]
Message-ID: <YoNDA0SOFjyoFlJS@infradead.org> (raw)
In-Reply-To: <1eb3b298-4f7e-32ad-74ae-12044ed637ed@openvz.org>
Please just use __FMODE_NONOTIFY instead, which might be a bit misnamed,
but was added exactly for this kind of use.
And remember once more: __force casts are a massive code smell. Never
add them before thinking hard about them and adding a comment explaining
why they can't be avoided, preferably in a dedicated helper.
next prev parent reply other threads:[~2022-05-17 6:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-14 10:22 [PATCH] sparse: use force attribute for fmode_t casts Vasily Averin
2022-05-16 11:18 ` Jan Kara
2022-05-16 11:47 ` Christian Brauner
2022-05-17 6:38 ` Christoph Hellwig [this message]
2022-05-18 10:49 ` [PATCH v2] sparse: fix incorrect " Vasily Averin
2022-05-18 11:12 ` Jan Kara
2022-05-18 13:22 ` Christoph Hellwig
2022-05-18 14:44 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoNDA0SOFjyoFlJS@infradead.org \
--to=hch@infradead.org \
--cc=amir73il@gmail.com \
--cc=jack@suse.cz \
--cc=kernel@openvz.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=repnop@google.com \
--cc=viro@zeniv.linux.org.uk \
--cc=vvs@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).