From: Al Viro <viro@zeniv.linux.org.uk>
To: ChenXiaoSong <chenxiaosong2@huawei.com>
Cc: miklos@szeredi.hu, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, liuyongqiang13@huawei.com,
yi.zhang@huawei.com, zhangxiaoxu5@huawei.com
Subject: Re: [PATCH -next] fuse: return the more nuanced writeback error on close()
Date: Wed, 18 May 2022 14:51:57 +0000 [thread overview]
Message-ID: <YoUIDcOmfJ5lppu3@zeniv-ca.linux.org.uk> (raw)
In-Reply-To: <20220518145729.2488102-1-chenxiaosong2@huawei.com>
On Wed, May 18, 2022 at 10:57:29PM +0800, ChenXiaoSong wrote:
> + /* return more nuanced writeback errors */
> if (err)
> - return err;
> + return filemap_check_wb_err(file->f_mapping, 0);
>
> err = 0;
As an aside, what the hell is that err = 0 about? Before or after
that patch, that is - "let's make err zero, in case it had somehow
magically changed ceased to be so since if (err) bugger_off just above"?
next prev parent reply other threads:[~2022-05-18 14:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 14:57 [PATCH -next] fuse: return the more nuanced writeback error on close() ChenXiaoSong
2022-05-18 14:51 ` Al Viro [this message]
2022-05-23 1:23 ` chenxiaosong (A)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoUIDcOmfJ5lppu3@zeniv-ca.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=chenxiaosong2@huawei.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyongqiang13@huawei.com \
--cc=miklos@szeredi.hu \
--cc=yi.zhang@huawei.com \
--cc=zhangxiaoxu5@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).