From: Matthew Wilcox <willy@infradead.org>
To: Zorro Lang <zlang@redhat.com>
Cc: Amir Goldstein <amir73il@gmail.com>,
Luis Chamberlain <mcgrof@kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-block <linux-block@vger.kernel.org>,
pankydev8@gmail.com, Theodore Tso <tytso@mit.edu>,
Josef Bacik <josef@toxicpanda.com>,
jmeneghi@redhat.com, Jan Kara <jack@suse.cz>,
Davidlohr Bueso <dave@stgolabs.net>,
Dan Williams <dan.j.williams@intel.com>, Jake Edge <jake@lwn.net>,
Klaus Jensen <its@irrelevant.dk>,
fstests <fstests@vger.kernel.org>
Subject: Re: [RFC: kdevops] Standardizing on failure rate nomenclature for expunges
Date: Thu, 19 May 2022 15:58:31 +0100 [thread overview]
Message-ID: <YoZbF90qS+LlSDfS@casper.infradead.org> (raw)
In-Reply-To: <20220519112450.zbje64mrh65pifnz@zlang-mailbox>
On Thu, May 19, 2022 at 07:24:50PM +0800, Zorro Lang wrote:
> Yes, we talked about this, but if I don't rememeber wrong, I recommended each
> downstream testers maintain their own "testing data/config", likes exclude
> list, failed ratio, known failures etc. I think they're not suitable to be
> fixed in the mainline fstests.
This assumes a certain level of expertise, which is a barrier to entry.
For someone who wants to check "Did my patch to filesystem Y that I have
never touched before break anything?", having non-deterministic tests
run by default is bad.
As an example, run xfstests against jfs. Hundreds of failures, including
some very scary-looking assertion failures from the page allocator.
They're (mostly) harmless in fact, just being a memory leak, but it
makes xfstests useless for this scenario.
Even for well-maintained filesystems like xfs which is regularly tested,
I expect generic/270 and a few others to fail. They just do, and they're
not an indication that *I* broke anything.
By all means, we want to keep tests around which have failures, but
they need to be restricted to people who have a level of expertise and
interest in fixing long-standing problems, not people who are looking
for regressions.
next prev parent reply other threads:[~2022-05-19 14:58 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 3:07 [RFC: kdevops] Standardizing on failure rate nomenclature for expunges Luis Chamberlain
2022-05-19 6:36 ` Amir Goldstein
2022-05-19 7:58 ` Dave Chinner
2022-05-19 9:20 ` Amir Goldstein
2022-05-19 15:36 ` Josef Bacik
2022-05-19 16:18 ` Zorro Lang
2022-05-19 11:24 ` Zorro Lang
2022-05-19 14:18 ` Theodore Ts'o
2022-05-19 15:10 ` Zorro Lang
2022-05-19 14:58 ` Matthew Wilcox [this message]
2022-05-19 15:44 ` Zorro Lang
2022-05-19 16:06 ` Matthew Wilcox
2022-05-19 16:54 ` Zorro Lang
2022-07-01 23:36 ` Luis Chamberlain
2022-07-02 17:01 ` Theodore Ts'o
2022-07-07 21:36 ` Luis Chamberlain
2022-07-02 21:48 ` Bart Van Assche
2022-07-03 5:56 ` Amir Goldstein
2022-07-03 13:15 ` Theodore Ts'o
2022-07-03 14:22 ` Amir Goldstein
2022-07-03 16:30 ` Theodore Ts'o
2022-07-04 3:25 ` Dave Chinner
2022-07-04 7:58 ` Amir Goldstein
2022-07-05 2:29 ` Theodore Ts'o
2022-07-05 3:11 ` Dave Chinner
2022-07-06 10:11 ` Amir Goldstein
2022-07-06 14:29 ` Theodore Ts'o
2022-07-06 16:35 ` Amir Goldstein
2022-07-03 13:32 ` Theodore Ts'o
2022-07-03 14:54 ` Bart Van Assche
2022-07-07 21:16 ` Luis Chamberlain
2022-07-07 21:06 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoZbF90qS+LlSDfS@casper.infradead.org \
--to=willy@infradead.org \
--cc=amir73il@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=dave@stgolabs.net \
--cc=fstests@vger.kernel.org \
--cc=its@irrelevant.dk \
--cc=jack@suse.cz \
--cc=jake@lwn.net \
--cc=jmeneghi@redhat.com \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=pankydev8@gmail.com \
--cc=tytso@mit.edu \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).