From: Mike Rapoport <rppt@kernel.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: Freeing page flags
Date: Mon, 23 May 2022 09:38:23 +0300 [thread overview]
Message-ID: <Yosr35sTk3l9nBy1@kernel.org> (raw)
In-Reply-To: <Yn10Iz1mJX1Mu1rv@casper.infradead.org>
On Thu, May 12, 2022 at 09:54:59PM +0100, Matthew Wilcox wrote:
> The LWN writeup [1] on merging the MGLRU reminded me that I need to send
> out a plan for removing page flags that we can do without.
>
> 4. I think I can also consolidate PG_slab and PG_reserved into a "single
> bit" (not really, but change the encoding so that effectively they only
> take a single bit).
PG_reserved could be a PageType, AFAIR no reserved pages are ever mapped to
userspace
> That gives us 4 bits back, which should relieve the pressure on page flag
> bits for a while. I have Thoughts on PG_private_2 and PG_owner_priv_1,
> as well as a suspicion that not all combinations of referenced, lru,
> active, workingset, reclaim and unevictable are possible, and there
> might be scope for a better encoding. But I don't know that we need to
> do that work; gaining back 4 bits is already a Big Deal.
>
> I'm slowly doing the PG_private transition as part of the folio work.
> For example, eagle eyed reviewers may have spotted that there is no
> folio_has_buffers(). Converted code calls folio_buffers() and checks
> if it's NULL. Help from filesystem maintainers on removing the uses of
> PG_error gratefully appreciated.
>
> [1] https://lwn.net/Articles/894859/
>
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2022-05-23 7:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 20:54 Freeing page flags Matthew Wilcox
2022-05-13 2:41 ` Josef Bacik
2022-05-13 3:39 ` Matthew Wilcox
2022-05-13 9:40 ` Luís Henriques
2022-05-13 12:53 ` Matthew Wilcox
2022-05-13 13:18 ` Luís Henriques
2022-05-13 13:21 ` Jeff Layton
2022-05-13 13:38 ` Matthew Wilcox
2022-05-13 13:57 ` Jeff Layton
2022-05-17 0:34 ` Xiubo Li
2022-05-13 13:17 ` Josef Bacik
2022-05-13 3:46 ` Yu Zhao
2022-05-14 6:10 ` Eric Biggers
2022-05-23 6:38 ` Mike Rapoport [this message]
2022-06-10 17:39 ` David Hildenbrand
2022-05-30 16:54 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yosr35sTk3l9nBy1@kernel.org \
--to=rppt@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).