From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id DF3A9C433EF
	for <linux-fsdevel@archiver.kernel.org>; Sat, 28 May 2022 05:48:49 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1343606AbiE1Fst (ORCPT
        <rfc822;linux-fsdevel@archiver.kernel.org>);
        Sat, 28 May 2022 01:48:49 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55776 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S230222AbiE1Fsr (ORCPT
        <rfc822;linux-fsdevel@vger.kernel.org>);
        Sat, 28 May 2022 01:48:47 -0400
Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99EE16007E
        for <linux-fsdevel@vger.kernel.org>; Fri, 27 May 2022 22:48:46 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version
        :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description;
        bh=MU/ma1wEaxhZh/yzRLApo+mAqCmQPAA3I0tYnpBA2E8=; b=3XkWGsngHxDglTSsW5JQ3AtdWL
        yWVWV60wyt+PHO4QGcIYLZcNPZccOeRbgFj3RHRbC+lHo1Bz6CmSDFOe32bvu67Dd8jIv47mt8+Nf
        rSLptQvUak6dCa7xRWrzKVytRrr12S7hgtjPql1k84GQsEUrBYHArdMvHM1d2TKwz3yCNjISnSZ6m
        7/t2XPuKdLiqtUDohwee5l9dkpgiYhO+cOMTqtd04hu4kLWaX1Rqh6V/D0BRkPvIZ8583MCl0yXjf
        +v3H/1Qcj3s6Y9aTBjFqR7yEYmMPJrl2eatv7ctYm7HI89oGPC9duHxQc8SAXSggiJj0Irna9rKbV
        jkFnSc7Q==;
Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux))
        id 1nupJe-001VNZ-8h; Sat, 28 May 2022 05:48:46 +0000
Date:   Fri, 27 May 2022 22:48:46 -0700
From:   Christoph Hellwig <hch@infradead.org>
To:     "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc:     linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 06/24] hfsplus: Remove check for PageError
Message-ID: <YpG3vqtxhm9qhwA8@infradead.org>
References: <20220527155036.524743-1-willy@infradead.org>
 <20220527155036.524743-7-willy@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220527155036.524743-7-willy@infradead.org>
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html
Precedence: bulk
List-ID: <linux-fsdevel.vger.kernel.org>
X-Mailing-List: linux-fsdevel@vger.kernel.org

On Fri, May 27, 2022 at 04:50:18PM +0100, Matthew Wilcox (Oracle) wrote:
> If read_mapping_page() encounters an error, it returns an errno, not a
> page with PageError set, so this is dead code.

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>